Optional Argument Validation Fails for ®

[robmeek]

I had another instance of #99, this time with a trader name containing the registered trademark character: ®

I asked ChatGPT for some other characters commonly used in the west which are marked as invalid by the current regex. It came up with:

    Currency symbols: $, €, £, ¥, etc.
    Special characters: @, #, %, *, !, ?, ;, :, etc.
    Quotation marks: ", ', ``, '', etc.
    Brackets: [, ], {, }, <, >
    Other punctuation marks: _, =, ~, ^, , |, etc.

With sincere respect and gratefulness for your work on this library, the VIES service is an open, public sector API which is surely protected from the kinds of naive attacks which the regex is intended to prevent. I think this library could remove this layer of validation. ($vies->validateArgument) I can’t see that it would be irresponsible to do so. Or am I missing something?

[robmeek]

Regex fix for ®

^[a-zA-Z0-9\s\.\-,&\+\(\)\/º\pL®]+$

[robmeek]

As a workaround for myself going forward I am now “precleaning” these optional arguments – stripping away everything which the regex will not accept as valid before I pass them to this library, e.g.

        $clean = function($s) {
            return preg_replace('/[^\p{L}0-9\s\.\-,&\+\(\)\/º]/u', '', $s);
        };

I think that will work fine for me, perhaps for others too.