Skip to content

Commit 13fe980

Browse files
authored
remove the version-based condition on the loading of SVG support stylesheet (#264)
* remove the version-based condition on the loading of svg.css vs. svg-with-js.css * remove unused $version param
1 parent 9433642 commit 13fe980

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

includes/class-fontawesome-release-provider.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -552,9 +552,7 @@ public static function get_option() {
552552
* @return FontAwesome_Resource
553553
*/
554554
public function get_svg_styles_resource( $version ) {
555-
$file_basename = ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] )
556-
? 'svg'
557-
: 'svg-with-js';
555+
$file_basename = 'svg-with-js';
558556

559557
$cdn_url_template = null;
560558

includes/class-fontawesome-svg-styles-manager.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,8 @@ public static function selfhost_asset_subdir( $version ) {
109109
* @ignore
110110
* @internal
111111
*/
112-
public static function selfhost_asset_filename( $version ) {
113-
return ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] )
114-
? 'svg.css'
115-
: 'svg-with-js.css';
112+
public static function selfhost_asset_filename() {
113+
return 'svg-with-js.css';
116114
}
117115

118116
/**

0 commit comments

Comments
 (0)