Skip to content

synchronize RelationalKeyspaceProvider.registerDomainIfExists #4337

Description

@ScottDugas

Reference Commits: 95583247c
Files (primary):
fdb-relational-core/.../RelationalKeyspaceProvider.java
Depends on: none

RelationalKeyspaceProvider is a JVM-wide singleton whose registerDomainIfExists mutated an internal map without a lock. Under parallel FRL construction this occasionally lost updates and duplicated domain registrations.

Wrap the read-then-mutate in a synchronized block, optionally taking a double-check approach so that we only synchronize if it doesn't already exist at the beginning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions