Skip to content

Commit 5981d21

Browse files
committed
doc: correct the catalog_server_explain claim for a new builtin log
The design doc says `catalog_server_explain.slt` needs no change when a builtin log is added, on the grounds that its query filters `o.id NOT LIKE 'si%'` and so never enumerates a per-replica introspection index. The filter is real, but the conclusion does not follow. The plans already in the file embed the inlined builtin `VALUES` sets as `Constant (N rows)` nodes, so every count over a catalog relation that gained a row moves, and adding an ontology entity and link moves two more. Record the question that catches this: not whether a new plan appears, but whether the existing plans change. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ZVCMBSLdxzGus78ZKWhZz
1 parent fab1acf commit 5981d21

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

doc/developer/design/20260817_compute_hydration_timestamps.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -737,9 +737,15 @@ Goldens that hardcode a log relation's identity, columns, OIDs or indexes:
737737
`test/workload-replay/system_catalog_identifiers.txt` and `objects.txt`. Docs: the
738738
`mz_introspection` system catalog reference page.
739739

740-
`catalog_server_explain.slt` and `test/cluster/mzcompose.py` need no change. The
741-
former's query filters `o.id NOT LIKE 'si%'`, which excludes per-replica
742-
introspection log indexes, and the latter queries named relations.
740+
`catalog_server_explain.slt` needs its `Constant (N rows)` counts bumped. Its query
741+
filters `o.id NOT LIKE 'si%'`, so no new EXPLAIN entry appears for the per-replica
742+
log index, but the existing plans embed the inlined builtin `VALUES` sets as
743+
constant nodes, so every count over a catalog relation that gained a row moves,
744+
including the two ontology counts moved by the new entity and link. The question a
745+
new builtin raises here is not whether a plan is added but whether the existing
746+
plans change.
747+
748+
`test/cluster/mzcompose.py` needs no change, since it queries named relations.
743749

744750
Not touched, and deliberately so: the introspection subscribe,
745751
`mz_internal.mz_compute_hydration_times`,

0 commit comments

Comments
 (0)