EntityManager::copy works incorrectly on a remote client

[MarcinSc]

When I copy an entity on a remote client and then modify the values of the components in the copy, the original is also getting modified.

Immortius thinks it might be

"probably you lose the original, because the entityref will get directed to the last registered thing with the given net id".

[MarcinSc]

Most likely causing #1048

[immortius]

Arguably it is working as intended - it creates a copy of the entity, and the entity system doesn't know about the behavior of the components being copied, nor should it have to.

Probably the item system should not be doing a straight copy, and instead doing a copy excluding the NetworkComponent. A helper method to do this would be good.

I will also have a look and see if there is some way for the client to differentiate between replicated entities and created locally entities for the purpose of the network system ignoring the latter, or at least whining loudly when it occurs.

[MarcinSc]

I'm not sure, isn't NetworkComponent something that EntityManager uses internally? If so, maybe the publicly exposed method should not be copying it this one component if it further confuses the EntityManager.

[immortius]

The entity manager knows nothing of NetworkComponent, and does not use it internally. The only components the entity manager deals with specifically are EntityInfoComponent and LocationComponent, the latter probably being too much.

Perhaps this is somewhere a hook is needed for the network manager to apply behavior, will think about it.

[MarcinSc]

Maybe the entity should have a "copy/clone" method and the NetEntityRef should not copy the NetworkComponent?

[immortius]

That is a good idea.

[Cervator]

Bump - ran across this one while testing other new inventory stuff and multiplayer inventory issues are still around.