From f598e357737043f387bf0477c4b04dae1af89f75 Mon Sep 17 00:00:00 2001
From: soloturn <soloturn@gmail.com>
Date: Thu, 20 Aug 2026 23:40:54 +0200
Subject: [PATCH] fix(TypeHandlerLibrary): move
 StringRepresentationTypeHandlerTest's inner class to the end

Checkstyle's InnerTypeLast rule wants init blocks, constructors, fields
and methods before inner types - RecordingHandler was declared first,
ahead of the field and @Test methods that use it. Already on develop
(via 962df32fb), so every PR built since has been failing checkstyle on
a file they never touched.

No behavior change, just reordered.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../StringRepresentationTypeHandlerTest.java  | 40 +++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/subsystems/TypeHandlerLibrary/src/test/java/org/terasology/persistence/typeHandling/StringRepresentationTypeHandlerTest.java b/subsystems/TypeHandlerLibrary/src/test/java/org/terasology/persistence/typeHandling/StringRepresentationTypeHandlerTest.java
index d0400f31dc5..e2b25f8ba57 100644
--- a/subsystems/TypeHandlerLibrary/src/test/java/org/terasology/persistence/typeHandling/StringRepresentationTypeHandlerTest.java
+++ b/subsystems/TypeHandlerLibrary/src/test/java/org/terasology/persistence/typeHandling/StringRepresentationTypeHandlerTest.java
@@ -14,26 +14,6 @@
 
 class StringRepresentationTypeHandlerTest {
 
-    /**
-     * Records whether {@link #getFromString} was reached. The contract under test is not just
-     * "returns empty" but "never forwards null to the subclass" — asserting only on the returned
-     * Optional would still pass if a subclass happened to tolerate null and return null itself.
-     */
-    private static final class RecordingHandler extends StringRepresentationTypeHandler<String> {
-        private boolean getFromStringCalled;
-
-        @Override
-        public String getAsString(String item) {
-            return item;
-        }
-
-        @Override
-        public String getFromString(String representation) {
-            getFromStringCalled = true;
-            return representation;
-        }
-    }
-
     private final RecordingHandler typeHandler = new RecordingHandler();
 
     @Test
@@ -63,4 +43,24 @@ void ignoresNonStringData() {
         assertFalse(result.isPresent());
         assertFalse(typeHandler.getFromStringCalled);
     }
+
+    /**
+     * Records whether {@link #getFromString} was reached. The contract under test is not just
+     * "returns empty" but "never forwards null to the subclass" — asserting only on the returned
+     * Optional would still pass if a subclass happened to tolerate null and return null itself.
+     */
+    private static final class RecordingHandler extends StringRepresentationTypeHandler<String> {
+        private boolean getFromStringCalled;
+
+        @Override
+        public String getAsString(String item) {
+            return item;
+        }
+
+        @Override
+        public String getFromString(String representation) {
+            getFromStringCalled = true;
+            return representation;
+        }
+    }
 }