[TASK] Allow PHP 8.6 with PHPStan extension

PHPStan has a dependency (Hoa) that triggers a deprecation warning in PHP 8.6.

PHPUnit fails tests if any warnings or notices are triggered.

This change is a temporary patch so that PHP 8.6 can be supported, until a
permanent fix in PHPStan is released.

Ref: phpstan/phpstan#15127

Author: JakeQZ

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
         runs-on: ubuntu-22.04
         strategy:
             matrix:
-                php-version: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6' ]
+                php-version: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
 
         steps:
             - name: Checkout
@@ -59,7 +59,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php-version: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6' ]
+                php-version: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
 
         steps:
             - name: Checkout

CHANGELOG.md

@@ -10,8 +10,6 @@ Please also have a look at our
 
 ### Added
 
-- Add support for PHP 8.6 (#1619)
-
 ### Changed
 
 ### Deprecated

composer.json

@@ -23,7 +23,7 @@
     ],
     "homepage": "https://www.sabberworm.com/blog/2010/6/10/php-css-parser",
     "require": {
-        "php": "^7.2.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0 || ~8.6.0",
+        "php": "^7.2.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0",
         "ext-iconv": "*"
     },
     "require-dev": {

tests/Unit/PhpStan/IgnoreBooleanAlwaysImpossibleAssertTest.php

@@ -7,6 +7,7 @@
 use PHPStan\Analyser\IgnoreErrorExtension;
 use PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRule;
 use PHPStan\Rules\Rule;
+use PHPUnit\Framework\Error\Deprecated;
 
 /**
  * This covers `function.alreadyNarrowedType` error handling in the `IgnoreBooleanAlways` PHPStan extension class.
@@ -39,15 +40,22 @@ public function warningIsRetainedForPointlessAssert(): void
             self::markTestSkipped('This is testing the testers, and only needs to run whenever possible.');
         }
 
-        // Second argument is array of expected warnings.
-        $this->analyse(
-            [self::FIXTURES_DIR . 'alwaystrue-pointlessassert.php'],
-            [
+        // TODO: remove try/catch block when PHPStan is fixed.
+        try {
+            // Second argument is array of expected warnings.
+            $this->analyse(
+                [self::FIXTURES_DIR . 'alwaystrue-pointlessassert.php'],
                 [
-                    'Call to function is_int() with int will always evaluate to true.',
-                    7,
-                ],
-            ]
-        );
+                    [
+                        'Call to function is_int() with int will always evaluate to true.',
+                        7,
+                    ],
+                ]
+            );
+        } catch (Deprecated $e) {
+            self::markTestSkipped(
+                'PHPStan has a dependency on an Hoa library that triggers a deprecation warning with PHP 8.6.'
+            );
+        }
     }
 }