Keep the console inside PHP 8.1

Constants in traits are PHP 8.2, and this package supports 8.1, so the
directive names move from the trait that uses them to a class of their
own. CI caught it; my local PHP is 8.4 and the lowest I can install here
is 8.2, so nothing on this machine would have.

Neither PHPStan with phpVersion 80100 nor php-parser's version-aware
parser flags the construct, so there is no local guard to add — the 8.1
job in CI is the check. A scan for the other 8.2-8.4 additions found
nothing else.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AjUMv5rFTVJMr6F1J7bx7x

Author: ajthinking

src/Console/Commands/ClassConstantCommand.php

@@ -4,6 +4,7 @@
 
 use Archetype\Console\EndpointCommand;
 use Archetype\Console\Support\Code;
+use Archetype\Console\Support\Directives;
 use Archetype\Console\Support\Introspector;
 use Archetype\LaravelFile as File;
 use Archetype\Support\Types;
@@ -20,7 +21,7 @@ class ClassConstantCommand extends EndpointCommand
 
     protected function directives(): array
     {
-        return ['add', 'remove', 'clear', 'empty'];
+        return Directives::WRITING;
     }
 
     protected function hasValue(): bool

src/Console/Commands/ModelPropertyCommand.php

@@ -4,6 +4,7 @@
 
 use Archetype\Console\EndpointCommand;
 use Archetype\Console\Support\Code;
+use Archetype\Console\Support\Directives;
 use Archetype\Console\Support\Introspector;
 use Archetype\LaravelFile as File;
 use RuntimeException;
@@ -46,7 +47,7 @@ public function __construct(protected string $property = 'fillable')
 
     protected function directives(): array
     {
-        return ['add', 'remove', 'clear', 'empty'];
+        return Directives::WRITING;
     }
 
     protected function hasValue(): bool

src/Console/Commands/PropertyCommand.php

@@ -4,6 +4,7 @@
 
 use Archetype\Console\EndpointCommand;
 use Archetype\Console\Support\Code;
+use Archetype\Console\Support\Directives;
 use Archetype\Console\Support\Introspector;
 use Archetype\LaravelFile as File;
 use Archetype\Support\Types;
@@ -24,7 +25,7 @@ class PropertyCommand extends EndpointCommand
 
     protected function directives(): array
     {
-        return ['add', 'remove', 'clear', 'empty', 'public', 'protected', 'private', 'static'];
+        return array_merge(Directives::WRITING, Directives::VISIBILITY, ['static']);
     }
 
     protected function hasValue(): bool
@@ -70,7 +71,7 @@ protected function name(): string
      */
     protected function withVisibility(File $file, string $name): File
     {
-        foreach (['public', 'protected', 'private'] as $flag) {
+        foreach (Directives::VISIBILITY as $flag) {
             if ($this->option($flag)) {
                 return $file;
             }

src/Console/Concerns/HasDirectiveFlags.php

@@ -2,6 +2,7 @@
 
 namespace Archetype\Console\Concerns;
 
+use Archetype\Console\Support\Directives;
 use Archetype\LaravelFile as File;
 use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputOption;
@@ -16,22 +17,6 @@
  */
 trait HasDirectiveFlags
 {
-    /** directive method => flag description */
-    const DIRECTIVES = [
-        'add' => 'Add to what is there instead of replacing it',
-        'remove' => 'Remove it',
-        'clear' => 'Clear the default value, keeping the declaration',
-        'empty' => 'Empty it, keeping the declaration',
-        'full' => 'Answer with the fully qualified name',
-        'public' => 'Declare it public',
-        'protected' => 'Declare it protected',
-        'private' => 'Declare it private',
-        'static' => 'Declare it static',
-    ];
-
-    /** The directives that make an operation a write rather than a read. */
-    const WRITING_DIRECTIVES = ['add', 'remove', 'clear', 'empty'];
-
     /** Which directives this command's endpoint honours. */
     abstract protected function directives(): array;
 
@@ -54,7 +39,7 @@ protected function withDirectives(File $file): File
     /** True when the caller asked a question rather than for a change. */
     protected function isRead(): bool
     {
-        foreach (array_intersect($this->directives(), self::WRITING_DIRECTIVES) as $directive) {
+        foreach (array_intersect($this->directives(), Directives::WRITING) as $directive) {
             if ($this->option($directive)) {
                 return false;
             }
@@ -67,7 +52,7 @@ protected function isRead(): bool
     protected function guardDirectives(): void
     {
         $given = array_values(array_filter(
-            array_intersect($this->directives(), self::WRITING_DIRECTIVES),
+            array_intersect($this->directives(), Directives::WRITING),
             fn ($directive) => $this->option($directive)
         ));
 
@@ -78,7 +63,7 @@ protected function guardDirectives(): void
         }
 
         $visibility = array_values(array_filter(
-            ['public', 'protected', 'private'],
+            Directives::VISIBILITY,
             fn ($flag) => in_array($flag, $this->directives(), true) && $this->option($flag)
         ));
 
@@ -99,7 +84,7 @@ protected function directiveOptions(): array
                 $directive,
                 null,
                 InputOption::VALUE_NONE,
-                self::DIRECTIVES[$directive]
+                Directives::ALL[$directive]
             );
         }
 

src/Console/Support/Directives.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Archetype\Console\Support;
+
+/**
+ * The PHP API's directives, as the console names them.
+ *
+ * These live on a class rather than on the trait that uses them because
+ * constants in traits are PHP 8.2, and this package supports 8.1.
+ */
+class Directives
+{
+    /** directive method => flag description */
+    const ALL = [
+        'add' => 'Add to what is there instead of replacing it',
+        'remove' => 'Remove it',
+        'clear' => 'Clear the default value, keeping the declaration',
+        'empty' => 'Empty it, keeping the declaration',
+        'full' => 'Answer with the fully qualified name',
+        'public' => 'Declare it public',
+        'protected' => 'Declare it protected',
+        'private' => 'Declare it private',
+        'static' => 'Declare it static',
+    ];
+
+    /** The directives that make an operation a write rather than a read. */
+    const WRITING = ['add', 'remove', 'clear', 'empty'];
+
+    /** The directives that choose a visibility. */
+    const VISIBILITY = ['public', 'protected', 'private'];
+}