bump: scala 2.13.17 and 3.3.7 (#32825)

---------

Co-authored-by: Sebastian <sebastian.alfers@gmail.com>

Author: johanandren

.github/workflows/check-samples.yml

@@ -18,6 +18,9 @@ jobs:
   check-samples:
     name: Check Sample Projects
     runs-on: Akka-Default
+    env:
+      SCALA3_VERSION: 3.3.7
+
     steps:
       - name: Checkout Global Scripts
         # This MUST be before the main checkout or else the dynver will not work
@@ -77,7 +80,7 @@ jobs:
         run: |-
           cd samples/akka-quickstart-scala
           sbt test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test" -Dakka.version=`cat ~/.version`
 
       - name: Test akka-sample-cluster-java
         run: |-
@@ -88,7 +91,7 @@ jobs:
         run: |-
           cd samples/akka-sample-cluster-scala
           sbt test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test" -Dakka.version=`cat ~/.version`
 
       - name: Test akka-sample-distributed-data-java
         run: |-
@@ -100,7 +103,7 @@ jobs:
         run: |-
           cd samples/akka-sample-distributed-data-scala
           sbt test multi-jvm:test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test; multi-jvm:test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test; multi-jvm:test" -Dakka.version=`cat ~/.version`
 
       - name: Test akka-sample-fsm-java
         run: |-
@@ -111,7 +114,7 @@ jobs:
         run: |-
           cd samples/akka-sample-fsm-scala
           sbt test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test" -Dakka.version=`cat ~/.version`
 
       - name: Test akka-sample-sharding-java
         run: |-
@@ -122,13 +125,13 @@ jobs:
         run: |-
           cd samples/akka-sample-sharding-scala
           sbt test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test" -Dakka.version=`cat ~/.version`
 
       - name: Test akka-sample-kafka-to-sharding-scala
         run: |-
           cd samples/akka-sample-kafka-to-sharding-scala
           sbt test -Dakka.version=`cat ~/.version`
-          sbt 'clean; ++3.3.3!; test' -Dakka.version=`cat ~/.version`
+          sbt "clean; ++${SCALA3_VERSION}!; test" -Dakka.version=`cat ~/.version`
 
       - name: Email on failure
         if: ${{ failure() }}

akka-actor-tests/src/test/scala/akka/actor/ActorSystemSpec.scala

@@ -77,7 +77,7 @@ object ActorSystemSpec {
 
   class SlowDispatcher(_config: Config, _prerequisites: DispatcherPrerequisites)
       extends MessageDispatcherConfigurator(_config, _prerequisites) {
-    private val instance = new Dispatcher(
+    private val instance: Dispatcher = new Dispatcher(
       this,
       this.config.getString("id"),
       this.config.getInt("throughput"),

akka-actor-tests/src/test/scala/akka/event/LoggingReceiveSpec.scala

@@ -93,7 +93,7 @@ class LoggingReceiveSpec extends AnyWordSpec with BeforeAndAfterAll {
           case null =>
         }
 
-        val actor = TestActorRef(new Actor {
+        val actor: TestActorRef[Actor] = TestActorRef(new Actor {
           def switch: Actor.Receive = { case "becomenull" => context.become(r, false) }
           def receive =
             switch.orElse(LoggingReceive {

akka-actor-typed/src/main/scala/akka/actor/typed/internal/adapter/PropsAdapter.scala

@@ -16,12 +16,15 @@ import akka.actor.typed.internal.PropsImpl._
 import akka.annotation.InternalApi
 import akka.dispatch.Mailboxes
 
+import scala.annotation.nowarn
+
 /**
  * INTERNAL API
  */
 @InternalApi private[akka] object PropsAdapter {
 
   private final val TypedCreatorFunctionConsumerClazz = classOf[TypedCreatorFunctionConsumer]
+  @nowarn("msg=never used")
   private final val ActorAdapterClazz = classOf[ActorAdapter[_]]
   private final val DefaultTypedDeploy = Deploy.local.copy(mailbox = "akka.actor.typed.default-mailbox")
 

akka-actor/src/main/scala-2.13/akka/util/ByteString.scala

@@ -361,7 +361,7 @@ object ByteString {
     }
 
     def compact: CompactByteString =
-      if (isCompact) ByteString1C(bytes) else ByteString1C(toArray)
+      if (isCompact) ByteString1C(bytes) else ByteString1C(toArray())
 
     def asByteBuffer: ByteBuffer = {
       val buffer = ByteBuffer.wrap(bytes, startIndex, length).asReadOnlyBuffer
@@ -441,7 +441,7 @@ object ByteString {
 
     override def toArrayUnsafe(): Array[Byte] = {
       if (startIndex == 0 && length == bytes.length) bytes
-      else toArray
+      else toArray()
     }
   }
 
@@ -833,7 +833,7 @@ sealed abstract class ByteString
    *
    * @return this ByteString copied into a byte array
    */
-  protected[ByteString] def toArray: Array[Byte] = toArray[Byte]
+  protected[ByteString] def toArray(): Array[Byte] = toArray[Byte]
 
   final override def toArray[B >: Byte](implicit arg0: ClassTag[B]): Array[B] = {
     // super uses byteiterator
@@ -869,7 +869,7 @@ sealed abstract class ByteString
    * only read the bytes and never mutate then. For all other intents and purposes, please use the usual
    * toArray method - which provide the immutability guarantees by copying the backing array.
    */
-  def toArrayUnsafe(): Array[Byte] = toArray
+  def toArrayUnsafe(): Array[Byte] = toArray()
 
   override def foreach[@specialized U](f: Byte => U): Unit = iterator.foreach(f)
 
@@ -932,7 +932,7 @@ sealed abstract class ByteString
    * Creates a new ByteBuffer with a copy of all bytes contained in this
    * ByteString.
    */
-  def toByteBuffer: ByteBuffer = ByteBuffer.wrap(toArray)
+  def toByteBuffer: ByteBuffer = ByteBuffer.wrap(toArray())
 
   /**
    * Decodes this ByteString as a UTF-8 encoded String.

akka-actor/src/main/scala/akka/actor/Address.scala

@@ -7,13 +7,13 @@ import java.net.MalformedURLException
 import java.net.URI
 import java.net.URISyntaxException
 import java.util.Optional
-
 import scala.annotation.tailrec
 import scala.collection.immutable
 import scala.jdk.OptionConverters._
-
 import akka.annotation.InternalApi
 
+import scala.annotation.nowarn
+
 /**
  * The address specifies the physical location under which an Actor can be
  * reached. Examples are local addresses, identified by the ActorSystem’s
@@ -65,8 +65,8 @@ final case class Address private[akka] (protocol: String, system: String, host:
    * entity.
    */
   def hasGlobalScope: Boolean = host.isDefined
-
   // store hashCode
+  @nowarn("msg=deprecated")
   @transient override lazy val hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
 
   /**

akka-actor/src/main/scala/akka/routing/RouterConfig.scala

@@ -81,7 +81,7 @@ trait RouterConfig extends Serializable {
   /**
    * Overridable merge strategy, by default completely prefers `this` (i.e. no merge).
    */
-  def withFallback(@nowarn("msg=never used") other: RouterConfig): RouterConfig = this
+  def withFallback(other: RouterConfig): RouterConfig = this
 
   /**
    * Check that everything is there which is needed. Called in constructor of RoutedActorRef to fail early.

akka-docs/src/test/scala/docs/persistence/testkit/TestKitExamples.scala

@@ -22,7 +22,6 @@ object PersistenceTestKitSampleSpec {
     val empty: State = new State
   }
   final class State extends CborSerializable {
-    @nowarn("msg=never used")
     def updated(event: Evt): State = this
   }
 }

akka-persistence-testkit/src/main/scala/akka/persistence/testkit/internal/Unpersistent.scala

@@ -109,7 +109,7 @@ private[akka] object Unpersistent {
 
     private var sequenceNr: Long = initialSequenceNr
     private var state: State = initialState
-    private var metadata: Option[Any] = None
+    private var metadataState: Option[Any] = None
     private val stashedCommands = ListBuffer.empty[Command]
 
     private def snapshotMetadata() =
@@ -143,7 +143,7 @@ private[akka] object Unpersistent {
 
           case Persist(event, metadataEntries) =>
             sequenceNr += 1
-            metadata = if (metadataEntries.isEmpty) None else Some(CompositeMetadata(metadataEntries))
+            metadataState = if (metadataEntries.isEmpty) None else Some(CompositeMetadata(metadataEntries))
             state = eventHandler(state, event)
             onEvent(event, sequenceNr, tagger(state, event))
             shouldSnapshot = shouldSnapshot || snapshotRequested(event)
@@ -155,7 +155,7 @@ private[akka] object Unpersistent {
                 val event = evtWithMeta.event
                 val metadataEntries = evtWithMeta.metadataEntries
                 sequenceNr += 1
-                metadata = if (metadataEntries.isEmpty) None else Some(CompositeMetadata(metadataEntries))
+                metadataState = if (metadataEntries.isEmpty) None else Some(CompositeMetadata(metadataEntries))
                 state = eventHandler(state, event)
                 val tags = tagger(state, event)
                 (event, sequenceNr, tags)
@@ -219,7 +219,7 @@ private[akka] object Unpersistent {
     }
 
     override def metadata[M: ClassTag]: Option[M] =
-      CompositeMetadata.extract[M](metadata)
+      CompositeMetadata.extract[M](metadataState)
   }
 
   private class WrappedDurableStateBehavior[Command, State](

akka-persistence/src/main/scala/akka/persistence/Eventsourced.scala

@@ -667,7 +667,7 @@ private[persistence] trait Eventsourced
    * @param replayMax maximum number of messages to replay.
    * @param timeout recovery event timeout
    */
-  private def recoveryStarted(replayMax: Long, timeout: FiniteDuration) = new State {
+  private def recoveryStarted(replayMax: Long, timeout: FiniteDuration): State = new State {
 
     val timeoutCancellable = {
       import context.dispatcher
@@ -783,7 +783,7 @@ private[persistence] trait Eventsourced
    *
    * All incoming messages are stashed.
    */
-  private def recovering(recoveryBehavior: Receive, timeout: FiniteDuration) =
+  private def recovering(recoveryBehavior: Receive, timeout: FiniteDuration): State =
     new State {
 
       // protect against snapshot stalling forever because of journal overloaded and such