Skip to content

punchable_type string limit 20 #32

Description

@PositiveControl

Is there a reason for punchable_type having limit => 20 character string in the db migration?

With nested/name-spaced models, this creates an issue:
Example Punchable class: Internal::Board::Event (22 chars)

ActiveRecord::ValueTooLong: Mysql2::Error: Data too long for column 'punchable_type' 

To fix the issue for my purpose, I rolled back the punches migration, removed the character limit, then migrated. No issues so far.

I'd be happy to submit an PR/MR to address this, but want to make sure that 20 char limit isn't there for a specific reason.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions