This repository was archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
dataClay's developer guide
aqueralt edited this page Mar 17, 2020
·
5 revisions
Clone the repo and install the needed dependencies:
git clone git@github.com:bsc-dom/dataclay-packaging.git
Initialize sub-modules
git submodule update --init --recursive
Add an upstream remote so you can easily keep up to date with the main repository:
git remote add upstream git@github.com:bsc-dom/dataclay-packaging.git
Now, follow the workflow to develop dataClay (skip sections you are not developing like javaclay or pyclay)
- Go to
dataclay-packaging/logicmodule/javaclaydirectory - Create a new branch. The name of the branch should start with:
-
feature/*: if you are developing a new feature -
bugfix/*: if you are fixing a bug -
enhancement/*: if you are developing an enhancement
-
git branch -b feature/my_new_feature
- Modify your code, commit and push your changes using
git commitandgit push - Go to https://github.com/bsc-dom/javaclay and create a PR:
- From your branch to
developbranch. Note that you cannot create a PR tomaster - Assign a reviewer
- Assign your PR to
dataClayproject - Add a reference to the GitHub issue being solved. Simply reference the issue in your commit message using any of the supported keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. For example:
this commit fixes #116
- From your branch to
-
Traviswill automatically run allunit testsfor your PR. If it fails, you'll receive an e-mail notification and the PR will not be accepted. Note that if your branch name does not follow naming conventionsTravisbuild will fail and you will have to move to another branch. You can check builds on Travis here: https://travis-ci.org/ - Once merged into
developbranch, acronjob will publish aSNAPSHOTofjavaclayinto Maven central repository. Remember that to appear in the public central maven repository it needs some time but you can check it in https://oss.sonatype.org/ repository -
dataclay-packagingnightly build will update submodules indevelopbranch and release your changes intoDockerHubif functional tests passes.
- Go to
dataclay-packaging/dspython/pyclaydirectory - Create a new branch. The name of the branch should start with:
-
feature/*: if you are developing a new feature -
bugfix/*: if you are fixing a bug -
enhancement/*: if you are developing an enhancement
-
git branch -b feature/my_new_feature
- Modify your code, commit and push your changes using
git commitandgit push - Go to https://github.com/bsc-dom/pyclay and create a PR:
- From your branch to
developbranch. Note that you cannot create a PR tomaster - Assign a reviewer
- Assign your PR to
dataClayproject - Add a reference to the GitHub issue being solved. Simply reference the issue in your commit message using any of the supported keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. For example:
this commit fixes #116
- From your branch to
-
Traviswill automatically run allunit testsfor your PR. If it fails, you'll receive an e-mail notification and the PR will not be accepted. Note that if your branch name does not follow naming conventionsTravisbuild will fail and you will have to move to another branch. You can check builds on Travis here: https://travis-ci.org/ - Once merged into
developbranch, acronjob will publish an development version ofpyclayinto https://test.pypi.org/project/dataClay/ repository. -
dataclay-packagingnightly build will update submodules indevelopbranch and release your changes intoDockerHubif functional tests passes.
This step is needed to update submodule references. This must be done after the PR is accepted and merged into develop
- Go to
dataclay-packaging/directory - Create a new branch. The name of the branch should start with:
-
feature/*: if you are developing a new feature -
bugfix/*: if you are fixing a bug -
enhancement/*: if you are developing an enhancement
-
git branch -b feature/my_new_feature
- Commit and push your changes using
git commitandgit pushso submodules references are updated. - Go to https://github.com/bsc-dom/dataclay-packaging and create a PR:
- From your branch to
developbranch. Note that you cannot create a PR tomaster - Assign a reviewer
- Assign your PR to
dataClayproject - Add a reference to the GitHub issue being solved. Simply reference the issue in your commit message using any of the supported keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. For example:
this commit fixes #116
- From your branch to
-
Traviswill automatically run all checks for your PR. If it fails, you'll receive an e-mail notification and the PR will not be accepted. Note that if your branch name does not follow naming conventionsTravisbuild will fail and you will have to move to another branch. You can check builds on Travis here: https://travis-ci.org/ - Once merged into
developbranch, acronjob will publish an development version ofdataclayinto DockerHub if functional tests passes.