Skip to content

Commit dbb05ab

Browse files
committed
revert to basic caged shapes for minor because major is still broken
1 parent da7fdba commit dbb05ab

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

src/frets/system/caged.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {
22
cagedPositionMapping,
3-
cagedPositionMappingMajor,
43
diatonicPatterns,
54
pentatonicPatterns,
65
pentatonicPositionMapping,
@@ -40,9 +39,8 @@ export default function caged(strings, scale) {
4039
// This aligns the patterns correctly with the scale degrees
4140
// const patternOffset = (noteCount === 5 && isMajor) ? 4 : 0;
4241
const patternOffset = isMajor ? 4 : 0;
43-
const basePositionMapping = isMajor && noteCount === 7 ? cagedPositionMappingMajor : cagedPositionMapping;
4442

45-
const cagedShapes = Object.entries(basePositionMapping).map(
43+
const cagedShapes = Object.entries(cagedPositionMapping).map(
4644
([pos, shape]) => {
4745
const basePattern = basePatterns[shape];
4846

src/frets/system/patterns.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ export const cagedPositionMapping = {
114114
5: "D",
115115
};
116116

117-
export const cagedPositionMappingMajor = {
118-
1: "A",
119-
2: "G",
120-
3: "E",
121-
4: "D",
122-
5: "C",
123-
}
117+
// export const cagedPositionMappingMajor = {
118+
// 1: "A",
119+
// 2: "G",
120+
// 3: "E",
121+
// 4: "D",
122+
// 5: "C",
123+
// }

0 commit comments

Comments
 (0)