Problem with NumberType and integers

[whataboutpereira]

Bug Report

Q	A
Version	4.4.3

Summary

Incorporating BcMath\Number I ran into an unexpected (or not) issue. Since NumberType only accepts Number when converting to database value, one cannot use integers as query parameters.

Current behavior

$repository->count(['number' => 0]);

will yield:

Could not convert PHP value 0 to type Doctrine\DBAL\Types\NumberType. Expected one of the following types: null, BcMath\Number

Expected behavior

Expected $repository->count(['number' => 0]); to keep working when number is BcMath\Number especially because comparisons between integer and Number are supported in PHP.

How to reproduce

Have an entity with a BcMath\Number field:

#[ORM\Column(type: Types::NUMBER, precision: 5, scale: 2)]
private BcMath\Number $number;

Try to get a count of all zero values:

$repository->count(['number' => 0]);

Unfortunately phpstan-doctrine won't catch these either.

[mikoajp]

NumberType::convertToDatabaseValue() only accepts null or BcMath\Number, but PHP natively supports comparisons between Number and int, so integers should be accepted too.

Proposed fix — convert int to Number before the instanceof check:

if (is_int($value)) {
    $value = new Number((string) $value);
}

if (! $value instanceof Number) {
    throw InvalidType::new($value, static::class, ['null', Number::class]);
}

return (string) $value;

Should I open a PR?