feat(payment_terms): Backfill and nullable column migrations

Author: D1353L

app/graphql/types/billing_entities/object.rb

@@ -25,7 +25,7 @@ class Object < Types::BaseObject
       field :address_line2, String
       field :city, String
       field :country, Types::CountryCodeEnum
-      field :net_payment_term, Integer, null: false
+      field :net_payment_term, Integer, null: true
       field :payment_term, Types::PaymentTerms::Object, null: true
       field :phone, String
       field :state, String

app/models/billing_entity.rb

@@ -96,7 +96,7 @@ class BillingEntity < ApplicationRecord
   validates :document_number_prefix, length: {minimum: 1, maximum: 10}, allow_nil: true, on: :create
   validates :document_number_prefix, length: {minimum: 1, maximum: 10}, on: :update
   validates :invoice_grace_period, numericality: {greater_than_or_equal_to: 0}
-  validates :net_payment_term, numericality: {greater_than_or_equal_to: 0}
+  validates :net_payment_term, numericality: {greater_than_or_equal_to: 0}, allow_nil: true
   validates :logo,
     image: {authorized_content_type: %w[image/png image/jpg image/jpeg], max_size: 800.kilobytes},
     if: :logo?
@@ -209,7 +209,7 @@ def validate_einvoicing
 #  legal_number                                 :string
 #  logo                                         :string
 #  name                                         :string           not null
-#  net_payment_term                             :integer          default(0), not null
+#  net_payment_term                             :integer          default(0)
 #  payment_term                                 :jsonb
 #  phone                                        :string
 #  state                                        :string

app/models/invoice.rb

@@ -768,7 +768,7 @@ def set_finalized_at
 #  finalized_at                            :datetime
 #  invoice_type                            :integer          default("subscription"), not null
 #  issuing_date                            :date
-#  net_payment_term                        :integer          default(0), not null
+#  net_payment_term                        :integer          default(0)
 #  number                                  :string           default(""), not null
 #  payment_attempts                        :integer          default(0), not null
 #  payment_dispute_lost_at                 :datetime

db/migrate/20260813134021_backfill_payment_terms.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+class BackfillPaymentTerms < ActiveRecord::Migration[8.0]
+  def up
+    safety_assured do
+      execute <<~SQL
+        UPDATE customers
+        SET payment_term = jsonb_build_object('term_type', 'net', 'days', net_payment_term)
+        WHERE payment_term IS NULL AND net_payment_term IS NOT NULL
+      SQL
+
+      execute <<~SQL
+        UPDATE billing_entities
+        SET payment_term = jsonb_build_object('term_type', 'net', 'days', net_payment_term)
+        WHERE payment_term IS NULL AND net_payment_term IS NOT NULL
+      SQL
+    end
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration, "backfilled payment terms cannot be distinguished from user values"
+  end
+end

db/migrate/20260813134550_relax_net_payment_term_nullability.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+class RelaxNetPaymentTermNullability < ActiveRecord::Migration[8.0]
+  def change
+    change_column_null :billing_entities, :net_payment_term, true
+    change_column_null :invoices, :net_payment_term, true
+  end
+end

db/structure.sql

@@ -2269,7 +2269,7 @@ CREATE TABLE public.billing_entities (
     finalize_zero_amount_invoice boolean DEFAULT true NOT NULL,
     invoice_footer text,
     invoice_grace_period integer DEFAULT 0 NOT NULL,
-    net_payment_term integer DEFAULT 0 NOT NULL,
+    net_payment_term integer DEFAULT 0,
     email character varying,
     email_settings character varying[] DEFAULT '{}'::character varying[] NOT NULL,
     eu_tax_management boolean DEFAULT false,
@@ -3609,7 +3609,7 @@ CREATE TABLE public.invoices (
     sub_total_excluding_taxes_amount_cents bigint DEFAULT 0 NOT NULL,
     sub_total_including_taxes_amount_cents bigint DEFAULT 0 NOT NULL,
     payment_due_date date,
-    net_payment_term integer DEFAULT 0 NOT NULL,
+    net_payment_term integer DEFAULT 0,
     voided_at timestamp(6) without time zone,
     organization_sequential_id integer DEFAULT 0 NOT NULL,
     ready_to_be_refreshed boolean DEFAULT false NOT NULL,
@@ -14176,6 +14176,8 @@ ALTER TABLE ONLY public.membership_roles
 SET search_path TO "$user", public;
 
 INSERT INTO "schema_migrations" (version) VALUES
+('20260813134550'),
+('20260813134021'),
 ('20260810135202'),
 ('20260805201143'),
 ('20260805110509'),
@@ -15277,4 +15279,3 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20220530091046'),
 ('20220526101535'),
 ('20220525122759');
-

schema.graphql

@@ -22,7 +22,7 @@
   it { is_expected.to have_field(:address_line2).of_type("String") }
   it { is_expected.to have_field(:city).of_type("String") }
   it { is_expected.to have_field(:country).of_type("CountryCode") }
-  it { is_expected.to have_field(:net_payment_term).of_type("Int!") }
+  it { is_expected.to have_field(:net_payment_term).of_type("Int") }
   it { is_expected.to have_field(:payment_term).of_type("PaymentTerm") }
   it { is_expected.to have_field(:state).of_type("String") }
   it { is_expected.to have_field(:zipcode).of_type("String") }

schema.json

@@ -86,6 +86,8 @@
       expect(billing_entity).to be_valid
     end
 
+    it { is_expected.to allow_value(nil).for(:net_payment_term) }
+
     it { is_expected.to validate_length_of(:document_number_prefix).is_at_least(1).is_at_most(10).on(:update) }
 
     it { is_expected.to allow_value(nil).for(:document_number_prefix).on(:create) }