feat(payment_terms): REST API write and read

Author: D1353L

app/controllers/api/v1/billing_entities_controller.rb

@@ -67,7 +67,7 @@ def update
       private
 
       def create_params
-        params.require(:billing_entity).permit(
+        permitted = params.require(:billing_entity).permit(
           :code,
           :name,
           :einvoicing,
@@ -99,10 +99,12 @@ def create_params
             :document_locale
           ]
         )
+
+        with_raw_payment_term(permitted, params[:billing_entity])
       end
 
       def update_params
-        params.require(:billing_entity).permit(
+        permitted = params.require(:billing_entity).permit(
           :name,
           :einvoicing,
           :email,
@@ -135,6 +137,20 @@ def update_params
           tax_codes: [],
           invoice_custom_section_codes: []
         )
+
+        with_raw_payment_term(permitted, params[:billing_entity])
+      end
+
+      # payment_term is a discriminated union validated in PaymentTerms::ValidateService.
+      # Strong params would silently drop null and non-hash values before validation,
+      # breaking clear-by-null and hiding invalid_format errors.
+      def with_raw_payment_term(permitted, raw)
+        if raw.respond_to?(:key?) && raw.key?(:payment_term)
+          permitted[:payment_term] = raw[:payment_term]
+          permitted[:payment_term].permit! if permitted[:payment_term].is_a?(ActionController::Parameters)
+        end
+
+        permitted
       end
 
       def resource_name

app/controllers/api/v1/customers_controller.rb

@@ -121,7 +121,7 @@ def checkout_url
       private
 
       def create_params
-        params.expect(customer: [
+        permitted = params.expect(customer: [
           :account_type,
           :external_id,
           :name,
@@ -191,6 +191,20 @@ def create_params
           tax_codes: [],
           invoice_custom_section_codes: []
         ])
+
+        with_raw_payment_term(permitted, params[:customer])
+      end
+
+      # payment_term is a discriminated union validated in PaymentTerms::ValidateService.
+      # Strong params would silently drop null and non-hash values before validation,
+      # breaking clear-by-null and hiding invalid_format errors.
+      def with_raw_payment_term(permitted, raw)
+        if raw.respond_to?(:key?) && raw.key?(:payment_term)
+          permitted[:payment_term] = raw[:payment_term]
+          permitted[:payment_term].permit! if permitted[:payment_term].is_a?(ActionController::Parameters)
+        end
+
+        permitted
       end
 
       def render_customer(customer)

app/serializers/v1/billing_entity_serializer.rb

@@ -23,6 +23,7 @@ def serialize
         legal_number: model.legal_number,
         timezone: model.timezone,
         net_payment_term: model.net_payment_term,
+        payment_term: model.payment_term,
         email_settings: model.email_settings,
         document_numbering: model.document_numbering,
         document_number_prefix: model.document_number_prefix,

app/serializers/v1/customer_serializer.rb

@@ -33,6 +33,7 @@ def serialize
         timezone: model.timezone,
         applicable_timezone: model.applicable_timezone,
         net_payment_term: model.net_payment_term,
+        payment_term: model.payment_term,
         external_salesforce_id: model.external_salesforce_id,
         finalize_zero_amount_invoice: model.finalize_zero_amount_invoice,
         billing_configuration:,

app/serializers/v1/invoice_serializer.rb

@@ -12,6 +12,7 @@ def serialize
         issuing_date: model.issuing_date&.iso8601,
         payment_due_date: model.payment_due_date&.iso8601,
         net_payment_term: model.net_payment_term,
+        payment_term: model.snapshotted_payment_term&.to_h,
         invoice_type: model.invoice_type,
         status: model.status,
         payment_status: model.payment_status,

app/services/billing_entities/create_service.rb

@@ -19,6 +19,10 @@ def initialize(organization:, params:)
     def call
       return result.forbidden_failure! unless organization.can_create_billing_entity?
 
+      unless PaymentTerms::ValidateService.new(result, payment_term: params[:payment_term]).valid?
+        return result
+      end
+
       ActiveRecord::Base.transaction do
         billing_entity.assign_attributes(create_attributes)
         billing_entity.id = params[:id] if params[:id]
@@ -77,7 +81,6 @@ def create_attributes
           legal_name
           legal_number
           name
-          net_payment_term
           phone
           state
           tax_identification_number

app/services/billing_entities/update_service.rb

@@ -19,6 +19,10 @@ def initialize(billing_entity:, params:)
     def call
       return result.not_found_failure!(resource: "billing_entity") unless billing_entity
 
+      unless PaymentTerms::ValidateService.new(result, payment_term: params[:payment_term]).valid?
+        return result
+      end
+
       original_attributes = billing_entity.attributes
       old_tax_codes = billing_entity.taxes.pluck(:code)
 

app/services/customers/create_service.rb

@@ -34,6 +34,10 @@ def call
         )
       end
 
+      unless PaymentTerms::ValidateService.new(result, payment_term: args[:payment_term]).valid?
+        return result
+      end
+
       customer = billing_entity.customers.new(
         organization_id: organization.id,
         external_id: args[:external_id],
@@ -56,7 +60,6 @@ def call
         logo_url: args[:logo_url],
         legal_name: args[:legal_name],
         legal_number: args[:legal_number],
-        net_payment_term: args[:net_payment_term],
         external_salesforce_id: args[:external_salesforce_id],
         payment_provider: args[:payment_provider],
         payment_provider_code: args[:payment_provider_code],

app/services/customers/update_service.rb

@@ -29,6 +29,10 @@ def call
         )
       end
 
+      unless PaymentTerms::ValidateService.new(result, payment_term: args[:payment_term]).valid?
+        return result
+      end
+
       old_payment_provider = customer.payment_provider
       old_provider_customer = customer.provider_customer
       original_tax_values = customer.slice(:tax_identification_number, :zipcode, :country).symbolize_keys

app/services/customers/upsert_from_api_service.rb

@@ -44,6 +44,10 @@ def call
         )
       end
 
+      unless PaymentTerms::ValidateService.new(result, payment_term: params[:payment_term]).valid?
+        return result
+      end
+
       ActiveRecord::Base.transaction do
         original_tax_values = customer.slice(:tax_identification_number, :zipcode, :country).symbolize_keys
 
@@ -71,7 +75,6 @@ def call
         customer.logo_url = params[:logo_url] if params.key?(:logo_url)
         customer.legal_name = params[:legal_name] if params.key?(:legal_name)
         customer.legal_number = params[:legal_number] if params.key?(:legal_number)
-        customer.net_payment_term = params[:net_payment_term] if params.key?(:net_payment_term)
         customer.external_salesforce_id = params[:external_salesforce_id] if params.key?(:external_salesforce_id)
         customer.finalize_zero_amount_invoice = params[:finalize_zero_amount_invoice] || "inherit" if params.key?(:finalize_zero_amount_invoice)
         customer.firstname = params[:firstname] if params.key?(:firstname)