fix(taxes): handle product fee tax changes

Author: endenis

app/models/fee.rb

@@ -60,6 +60,7 @@ class Fee < ApplicationRecord
   validates :events_count, numericality: {greater_than_or_equal_to: 0}, allow_nil: true
   validates :true_up_fee_id, presence: false, unless: :charge?
   validates :total_aggregated_units, presence: true, if: :charge?
+  validates :rate_card_rate, presence: true, if: :product?
 
   scope :positive_units, -> { where("fees.units > ?", 0) }
 

app/services/taxes/destroy_service.rb

@@ -51,10 +51,12 @@ def call
     attr_reader :tax
 
     def draft_invoice_ids
-      @draft_invoice_ids ||= tax.organization.invoices
+      @draft_invoice_ids ||= (
+        tax.organization.invoices
         .where(customer_id: tax.applicable_customers.select(:id))
         .draft
-        .pluck(:id)
+        .pluck(:id) + tax.draft_fee_taxes.distinct.pluck("fees.invoice_id")
+      ).uniq
     end
   end
 end

app/services/taxes/update_service.rb

@@ -15,6 +15,7 @@ def call
       return result.not_found_failure!(resource: "tax") unless tax
 
       customer_ids = tax.applicable_customers.select(:id).to_a
+      draft_invoice_ids = tax.draft_fee_taxes.distinct.pluck("fees.invoice_id")
 
       tax.name = params[:name] if params.key?(:name)
       tax.code = params[:code] if params.key?(:code)
@@ -26,8 +27,9 @@ def call
       manage_taxes_on_billing_entity if params.key?(:applied_to_organization)
 
       customer_ids = (customer_ids + tax.reload.applicable_customers.select(:id)).uniq
-      draft_invoices = tax.organization.invoices.where(customer_id: customer_ids).draft
-      draft_invoices.update_all(ready_to_be_refreshed: true) # rubocop:disable Rails/SkipsModelValidations
+      draft_invoice_ids |= tax.organization.invoices.where(customer_id: customer_ids).draft.pluck(:id)
+      tax.organization.invoices.where(id: draft_invoice_ids)
+        .update_all(ready_to_be_refreshed: true) # rubocop:disable Rails/SkipsModelValidations
 
       result.tax = tax
       result

spec/models/fee_spec.rb

@@ -19,6 +19,16 @@
   it { is_expected.to have_one(:true_up_fee).with_foreign_key(:true_up_parent_fee_id).class_name("Fee").dependent(:destroy) }
   it { is_expected.to belong_to(:original_fee).class_name("Fee").optional }
 
+  describe "validations" do
+    it "requires a Rate Card Rate for Product fees" do
+      fee = build(:fee, fee_type: :product, rate_card_rate: nil)
+
+      fee.validate
+
+      expect(fee.errors.of_kind?(:rate_card_rate, :blank)).to be(true)
+    end
+  end
+
   describe "#ordered_by_period" do
     let(:fee1) do
       create(:fee, properties: {

spec/services/taxes/destroy_service_spec.rb

@@ -23,6 +23,23 @@
       expect { destroy_service.call }.to change { draft_invoice.reload.ready_to_be_refreshed }.to(true)
     end
 
+    context "when the tax is applied only to a Rate Card" do
+      let(:tax) { create(:tax, organization:) }
+      let(:rate_card) { create(:rate_card, organization:) }
+      let(:rate_card_rate) { create(:rate_card_rate, organization:, rate_card:) }
+      let(:draft_invoice) { create(:invoice, :draft, organization:, customer:) }
+
+      before do
+        create(:rate_card_applied_tax, rate_card:, tax:, organization:)
+        fee = create(:product_fee, invoice: draft_invoice, rate_card_rate:)
+        create(:fee_applied_tax, fee:, tax:)
+      end
+
+      it "marks the draft invoice as ready to be refreshed" do
+        expect { destroy_service.call }.to change { draft_invoice.reload.ready_to_be_refreshed }.to(true)
+      end
+    end
+
     it "does not remove the other tax from the default billing entity" do
       expect { destroy_service.call }.to change { billing_entity.applied_taxes.count }.by(-1)
     end

spec/services/taxes/update_service_spec.rb

@@ -113,6 +113,23 @@
       expect { update_service.call }.to change { draft_invoice.reload.ready_to_be_refreshed }.to(true)
     end
 
+    context "when the tax is applied only to a Rate Card" do
+      let(:tax) { create(:tax, organization:) }
+      let(:rate_card) { create(:rate_card, organization:) }
+      let(:rate_card_rate) { create(:rate_card_rate, organization:, rate_card:) }
+      let(:draft_invoice) { create(:invoice, :draft, organization:, customer:) }
+
+      before do
+        create(:rate_card_applied_tax, rate_card:, tax:, organization:)
+        fee = create(:product_fee, invoice: draft_invoice, rate_card_rate:)
+        create(:fee_applied_tax, fee:, tax:)
+      end
+
+      it "marks the draft invoice as ready to be refreshed" do
+        expect { update_service.call }.to change { draft_invoice.reload.ready_to_be_refreshed }.to(true)
+      end
+    end
+
     context "when tax is not found" do
       let(:tax) { nil }