feat(payment_terms): PDF and e-invoice updates

Author: D1353L

app/models/payment_term.rb

@@ -57,6 +57,15 @@ def net_payment_term_alias
     end
   end
 
+  # Localized sentence for the term in the current I18n locale.
+  def label
+    if term_type == "day_of_month"
+      I18n.t("invoice.payment_terms.day_of_month.#{month_offset_variant}", day: day_of_month, months: month_offset)
+    else
+      I18n.t("invoice.payment_terms.#{term_type}", days:)
+    end
+  end
+
   def due_date_for(issuing_date)
     issuing_date = issuing_date.to_date
 
@@ -77,6 +86,14 @@ def carries?(field)
     FIELDS_BY_TERM_TYPE.fetch(term_type, []).include?(field)
   end
 
+  def month_offset_variant
+    case month_offset
+    when 0 then "same_month"
+    when 1 then "following_month"
+    else "months_after"
+    end
+  end
+
   # Only day_of_month terms carry a month_offset.
   # If absent - next month (1) by default.
   def normalized_month_offset(month_offset)

app/serializers/e_invoices/invoices/common.rb

@@ -44,7 +44,7 @@ def credits_and_payments(&block)
       end
 
       def payment_terms_description
-        "#{I18n.t("invoice.payment_term")} #{I18n.t("invoice.payment_term_days", net_payment_term: invoice.net_payment_term)}"
+        invoice.snapshotted_payment_term.label
       end
 
       def allowances

app/views/payment_request_mailer/requested.slim

@@ -4,8 +4,6 @@ div style="margin-bottom: 32px;font-style: normal;font-weight: 400;font-size: 16
   = I18n.t("email.payment_request.requested.reminder_overdue_balance", billing_entity_name: @billing_entity.name)
 div style="margin-bottom: 32px;font-style: normal;font-weight: 400;font-size: 16px;line-height: 24px;color: #19212E;"
   = I18n.t("email.payment_request.requested.total_amount_due", amount: MoneyHelper.format(@payment_request.amount))
-div style="margin-bottom: 32px;font-style: normal;font-weight: 400;font-size: 16px;line-height: 24px;color: #19212E;"
-    = I18n.t("email.payment_request.requested.payment_terms", count: @customer.applicable_net_payment_term)
 div style="margin-bottom: 32px;font-style: normal;font-weight: 400;font-size: 16px;line-height: 24px;color: #19212E;"
   = I18n.t("email.payment_request.requested.already_paid")
 div style="margin-bottom: 32px;font-style: normal;font-weight: 400;font-size: 16px;line-height: 24px;color: #19212E;"

app/views/templates/invoices/v3.slim

@@ -357,7 +357,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v3/charge.slim

@@ -351,7 +351,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v3/one_off.slim

@@ -352,7 +352,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v4.slim

@@ -440,7 +440,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v4/charge.slim

@@ -437,7 +437,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v4/fixed_charge.slim

@@ -430,7 +430,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?

app/views/templates/invoices/v4/one_off.slim

@@ -378,7 +378,7 @@ html
               td.body-2 = I18n.l(issuing_date, format: :default)
             tr
               td.body-1 = I18n.t('invoice.payment_term')
-              td.body-2 = I18n.t('invoice.payment_term_days', net_payment_term:)
+              td.body-2 = snapshotted_payment_term.label
         .invoice-information-column
           table.invoice-information-table
             - if customer.metadata.displayable.any?