Skip to content

Allow custom toolchains - #32

Closed
BobBeckett wants to merge 2 commits into
google:masterfrom
BobBeckett:custom-toolchain
Closed

Allow custom toolchains#32
BobBeckett wants to merge 2 commits into
google:masterfrom
BobBeckett:custom-toolchain

Conversation

@BobBeckett

@BobBeckett BobBeckett commented Jun 4, 2020

Copy link
Copy Markdown

A couple of changes used to build via a custom toolchain and sysroot.
With these changes, I was able to build for arm 32bit Linux with args.gn like:

target_os = "linux" target_cpu = "arm" is_debug = false is_clang = false target_sysroot = "/opt/PROJECT-sdk/sysroots/armv7ahf-neon-PROJECT-linux-gnueabi" target_triplet = "arm-PROJECT-linux-gnueabi" target_extra_cflags = "-mfloat-abi=hard"

gnu ld does not support "--icf" flags.

Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
allow the user to specify target_triplet and target_extra_cflags
to enable them to use their own custom compiler.
This is especially useful for cross compiling using SDK outputs
from build systems like yocto, which often have custom toolchain
prefixes.

Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
@primiano

primiano commented Jun 4, 2020

Copy link
Copy Markdown
Member

We don't take pull requests from github but are happy to take these sort of changes through AOSP Gerrit.
See https://perfetto.dev/docs/contributing/getting-started for instructions

@primiano primiano closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants