Fix up interactive repl checks (#950)

Author: jeaye

compiler+runtime/include/cpp/jtl/terminal.hpp

@@ -79,5 +79,6 @@ namespace jtl::terminal
   };
 
   size get_size();
-  bool is_interactive();
+  bool is_stdin_interactive();
+  bool is_stdout_interactive();
 }

compiler+runtime/src/cpp/jank/terminal_repl_client.cpp

@@ -187,7 +187,7 @@ namespace jank::terminal_repl
 
   static jtl::option<std::string> read_line(std::string const &prompt)
   {
-    if(!jtl::terminal::is_interactive())
+    if(!jtl::terminal::is_stdin_interactive())
     {
       std::string input;
       if(!std::getline(std::cin, input))
@@ -265,7 +265,7 @@ namespace jank::terminal_repl
       return __rt_ctx->current_ns()->name->to_code_string() + suffix;
     });
 
-    if(!jtl::terminal::is_interactive())
+    if(jtl::terminal::is_stdin_interactive())
     {
       ic_set_history(".jank-repl-history", 200);
       init_isocline();
@@ -351,7 +351,7 @@ namespace jank::terminal_repl
       __rt_ctx->in_ns_var->deref().call(make_box<obj::symbol>(util::cli::opts.target_module));
     }
 
-    if(!jtl::terminal::is_interactive())
+    if(jtl::terminal::is_stdin_interactive())
     {
       ic_set_history(".jank-native-repl-history", 200);
       init_isocline();

compiler+runtime/src/cpp/jtl/string_builder.cpp

@@ -306,7 +306,7 @@ namespace jtl
 
   string_builder &string_builder::operator()(terminal::text_style const s) &
   {
-    if(!terminal::is_interactive())
+    if(!terminal::is_stdout_interactive())
     {
       return *this;
     }

compiler+runtime/src/cpp/jtl/terminal.cpp

@@ -44,12 +44,22 @@ namespace jtl::terminal
 #endif
   }
 
-  bool is_interactive()
+  bool is_stdin_interactive()
   {
 #if defined(_WIN32)
     return true;
 #else
-    static bool const res{ isatty(STDIN_FILENO) != 0 && isatty(STDOUT_FILENO) != 0 };
+    static bool const res{ isatty(STDIN_FILENO) != 0 };
+    return res;
+#endif
+  }
+
+  bool is_stdout_interactive()
+  {
+#if defined(_WIN32)
+    return true;
+#else
+    static bool const res{ isatty(STDOUT_FILENO) != 0 };
     return res;
 #endif
   }

compiler+runtime/src/jank/jank/perf/core.jank

@@ -87,9 +87,10 @@ namespace jank::perf::core
   (when (and (cpp/jank.util.is_dynamic_runtime)
              (not= 3 (.-runtime_optimization_level cpp/jank.util.cli.opts)))
     (println (print/color :bright-red "warning:")
-             "The optimization level is"
+             "The current optimization level is"
              (str "-O" (.-runtime_optimization_level cpp/jank.util.cli.opts))
-             "while the max is -O3. Benchmarks results may vary greatly between optimization levels."))
+             "while the max is -O3.\n"
+             "        Benchmarks results may vary greatly between optimization levels."))
 
   (when (not= cpp/jank.util.cli.compilation_eagerness.eager
               (.-eagerness cpp/jank.util.cli.opts))