fix: correct BC guard in Issue::create(), IssueCategory::create(), Membership::create()

Author: Art4

src/Redmine/Api/Issue.php

@@ -258,8 +258,12 @@ public function create(array $params = [])
         $body = $this->lastResponse->getContent();
 
         if ($this->lastResponse->getStatusCode() !== 201) {
-            if (!Future::isForwardCompatibilityEnabled() && $body === '') {
-                return $body;
+            if (!Future::isForwardCompatibilityEnabled()) {
+                if ($body === '') {
+                    return $body;
+                }
+
+                return new SimpleXMLElement($body);
             }
 
             throw UnexpectedResponseException::create($this->lastResponse);

src/Redmine/Api/IssueCategory.php

@@ -269,8 +269,12 @@ public function create($project, array $params = [])
         $body = $this->lastResponse->getContent();
 
         if ($this->lastResponse->getStatusCode() !== 201) {
-            if (!Future::isForwardCompatibilityEnabled() && $body === '') {
-                return $body;
+            if (!Future::isForwardCompatibilityEnabled()) {
+                if ($body === '') {
+                    return $body;
+                }
+
+                return new SimpleXMLElement($body);
             }
 
             throw UnexpectedResponseException::create($this->lastResponse);

src/Redmine/Api/Membership.php

@@ -151,8 +151,12 @@ public function create($project, array $params = [])
         $body = $this->lastResponse->getContent();
 
         if ($this->lastResponse->getStatusCode() !== 201) {
-            if (!Future::isForwardCompatibilityEnabled() && $body === '') {
-                return $body;
+            if (!Future::isForwardCompatibilityEnabled()) {
+                if ($body === '') {
+                    return $body;
+                }
+
+                return new SimpleXMLElement($body);
             }
 
             throw UnexpectedResponseException::create($this->lastResponse);

tests/Unit/Api/Issue/CreateTest.php

@@ -265,6 +265,29 @@ public function testCreateWithIncorrectStatusCodeReturnsEmptyString(): void
         $this->assertSame('', $return);
     }
 
+    public function testCreateWithIncorrectStatusCodeReturnsBody(): void
+    {
+        $client = AssertingHttpClient::create(
+            $this,
+            [
+                'POST',
+                '/issues.xml',
+                'application/xml',
+                '<?xml version="1.0" encoding="UTF-8"?><issue/>',
+                500,
+                '',
+                '<error>error</error>',
+            ],
+        );
+
+        $api = Issue::fromHttpClient($client);
+
+        $return = $api->create([]);
+
+        $this->assertInstanceOf(SimpleXMLElement::class, $return);
+        $this->assertXmlStringEqualsXmlString('<error>error</error>', $return->asXml());
+    }
+
     public function testCreateWithIncorrectStatusCodeThrowsException(): void
     {
         $client = AssertingHttpClient::create(

tests/Unit/Api/IssueCategory/CreateTest.php

@@ -107,6 +107,29 @@ public function testCreateReturnsEmptyString(): void
         $this->assertSame('', $return);
     }
 
+    public function testCreateWithIncorrectStatusCodeReturnsBody(): void
+    {
+        $client = AssertingHttpClient::create(
+            $this,
+            [
+                'POST',
+                '/projects/5/issue_categories.xml',
+                'application/xml',
+                '<?xml version="1.0" encoding="UTF-8"?><issue_category><name>Test Category</name></issue_category>',
+                500,
+                '',
+                '<error>error</error>',
+            ],
+        );
+
+        $api = IssueCategory::fromHttpClient($client);
+
+        $return = $api->create(5, ['name' => 'Test Category']);
+
+        $this->assertInstanceOf(SimpleXMLElement::class, $return);
+        $this->assertXmlStringEqualsXmlString('<error>error</error>', $return->asXml());
+    }
+
     public function testCreateWithIncorrectStatusCodeThrowsException(): void
     {
         $client = AssertingHttpClient::create(

tests/Unit/Api/Membership/CreateTest.php

@@ -98,6 +98,29 @@ public function testCreateReturnsEmptyString(): void
         $this->assertSame('', $return);
     }
 
+    public function testCreateWithIncorrectStatusCodeReturnsBody(): void
+    {
+        $client = AssertingHttpClient::create(
+            $this,
+            [
+                'POST',
+                '/projects/5/memberships.xml',
+                'application/xml',
+                '<?xml version="1.0" encoding="UTF-8"?><membership><user_id>4</user_id><role_ids>2</role_ids></membership>',
+                500,
+                '',
+                '<error>error</error>',
+            ],
+        );
+
+        $api = Membership::fromHttpClient($client);
+
+        $return = $api->create(5, ['user_id' => 4, 'role_ids' => 2]);
+
+        $this->assertInstanceOf(SimpleXMLElement::class, $return);
+        $this->assertXmlStringEqualsXmlString('<error>error</error>', $return->asXml());
+    }
+
     public function testCreateThrowsExceptionWithEmptyParameters(): void
     {
         $client = $this->createStub(HttpClient::class);