Merge pull request #474 from kbsali/464-strict-types

declare strict_types in all files

Author: Art4

.php-cs-fixer.dist.php

@@ -14,6 +14,7 @@
         '@PER-CS3x0' => true,
         '@PER-CS3x0:risky' => true,
         '@PHPUnit100Migration:risky' => true,
+        'declare_strict_types' => true,
         'linebreak_after_opening_tag' => true,
         'ordered_imports' => true,
         'no_empty_phpdoc' => true,

src/Redmine/Api.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine;
 
 /**

src/Redmine/Api/AbstractApi.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use InvalidArgumentException;

src/Redmine/Api/Attachment.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/CustomField.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -149,7 +151,7 @@ public function listing($forceUpdate = false, array $params = [])
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNames()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate, $params);
+        return $this->doListing((bool) $forceUpdate, $params);
     }
 
     /**

src/Redmine/Api/Group.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -275,7 +277,7 @@ public function remove($id)
     {
         $this->lastResponse = $this->getHttpClient()->request(HttpFactory::makeXmlRequest(
             'DELETE',
-            '/groups/' . $id . '.xml',
+            '/groups/' . strval($id) . '.xml',
         ));
 
         return $this->lastResponse->getContent();
@@ -295,7 +297,7 @@ public function addUser($id, $userId)
     {
         $this->lastResponse = $this->getHttpClient()->request(HttpFactory::makeXmlRequest(
             'POST',
-            '/groups/' . $id . '/users.xml',
+            '/groups/' . strval($id) . '/users.xml',
             XmlSerializer::createFromArray(['user_id' => $userId])->getEncoded(),
         ));
 
@@ -322,7 +324,7 @@ public function removeUser($id, $userId)
     {
         $this->lastResponse = $this->getHttpClient()->request(HttpFactory::makeXmlRequest(
             'DELETE',
-            '/groups/' . $id . '/users/' . $userId . '.xml',
+            '/groups/' . strval($id) . '/users/' . strval($userId) . '.xml',
         ));
 
         return $this->lastResponse->getContent();

src/Redmine/Api/Issue.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/IssueCategory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -175,7 +177,7 @@ public function listing($project, $forceUpdate = false)
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNamesByProject()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($project, $forceUpdate);
+        return $this->doListing($project, (bool) $forceUpdate);
     }
 
     /**

src/Redmine/Api/IssuePriority.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/IssueRelation.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;