Skip to content

Commit 0a4c785

Browse files
mariusvniekerkcodex
andcommitted
test(agent-hook): use in-process review source
The regular daemon now owns Agent Hook review lookup. The acknowledgement regression test must exercise that in-process boundary instead of the removed hook-to-daemon HTTP path. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
1 parent 2bacc8d commit 0a4c785

1 file changed

Lines changed: 6 additions & 21 deletions

File tree

internal/agenthook/state_test.go

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,26 +1541,12 @@ func TestRecordPostToolUseAmendAfterBranchAttachmentDoesNotRepeatAcknowledgedRev
15411541

15421542
closed := false
15431543
verdict := "F"
1544-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
1545-
if r.URL.Path == "/api/repos/resolve" {
1546-
assert.NoError(json.NewEncoder(w).Encode(map[string]any{
1547-
"tracked": true,
1548-
"repo": map[string]string{
1549-
"root_path": repo.Path(),
1550-
"name": filepath.Base(repo.Path()),
1551-
},
1552-
}))
1553-
return
1554-
}
1555-
assert.NoError(json.NewEncoder(w).Encode(jobsResponse{
1556-
Jobs: []storage.ReviewJob{{
1557-
ID: 101, Status: storage.JobStatusDone, Closed: &closed, Verdict: &verdict, GitRef: reviewHead,
1558-
}},
1559-
}))
1560-
}))
1561-
t.Cleanup(server.Close)
1562-
1563-
store := &StateStore{path: filepath.Join(t.TempDir(), "state.json"), sessions: map[string]SessionState{}}
1544+
store := &StateStore{
1545+
reviews: reviewSourceWithJobs(storage.ReviewJob{
1546+
ID: 101, Status: storage.JobStatusDone, Closed: &closed, Verdict: &verdict, GitRef: reviewHead,
1547+
}),
1548+
path: filepath.Join(t.TempDir(), "state.json"), sessions: map[string]SessionState{},
1549+
}
15641550
baseReq := Request{
15651551
Event: Input{
15661552
SessionID: "session-1",
@@ -1572,7 +1558,6 @@ func TestRecordPostToolUseAmendAfterBranchAttachmentDoesNotRepeatAcknowledgedRev
15721558
CommitThreshold: 1,
15731559
FailedReviewThreshold: 1,
15741560
Instruction: "Resolve reviews.",
1575-
RoborevServerAddr: server.URL,
15761561
}
15771562

15781563
first, err := store.Record(baseReq)

0 commit comments

Comments
 (0)