Merge pull request #102 from node-red-contrib/codex/handle-routeros-empty-reply

Handle RouterOS 7.18 empty API replies

Author: konne

src/mikrotik.html.ts

@@ -20,8 +20,8 @@ RED.nodes.registerType('mikrotik', {
     oneditprepare: function () {
         let node = this;
         $("#node-input-action").on('change', function () {
-            let cmd = node.command;
-            let newType = 'str';
+            let cmd: string = node.command;
+            let newType: string = 'str';
 
             const lookUp = ['/log/print', '/system/resource/print', '/interface/wireless/registration-table/print', '/system/reboot'];
             let value = parseInt($("#node-input-action").val() as string, 10);
@@ -47,4 +47,4 @@ RED.nodes.registerType('mikrotik', {
     oneditsave: function () {
         this.action = null;
     }
-});
+});

src/mikrotik.ts

@@ -2,6 +2,28 @@ import { NodeAPI, Node, NodeMessageInFlow } from "node-red";
 import { MikrotikDeviceNode } from "./interfaces"
 
 import { RouterOSAPI } from "node-routeros";
+import { Channel } from "node-routeros/dist/Channel";
+
+function patchRouterOSEmptyReply() {
+    const channelPrototype = Channel.prototype as any;
+    if (channelPrototype.handlesRouterOSEmptyReply)
+        return;
+
+    const processPacket = channelPrototype.processPacket;
+    channelPrototype.processPacket = function (packet: string[]) {
+        // RouterOS 7.18 sends !empty before !done when a query has no records.
+        if (packet[0] === '!empty') {
+            packet.shift();
+            return;
+        }
+
+        return processPacket.call(this, packet);
+    };
+
+    channelPrototype.handlesRouterOSEmptyReply = true;
+}
+
+patchRouterOSEmptyReply();
 
 export = function (RED: NodeAPI) {
     function NodeMikrotik(this: Node, config: any) {

tsconfig.json

@@ -9,7 +9,9 @@
         "allowJs": false,
         "declaration": false,
         "sourceMap": false,
+        "skipLibCheck": true,
         "strict": false,
+        "rootDir": "./src",
         "outDir": "./nodes/",
     },