Commit 6a70cf0
ship: never
Found while shipping 2.0.0. Step 9 prescribed `sbt clean test publish`, and
bare `test` in sbt 2 resolves to testQuick, which skips suites it judges
unaffected. That judgement SURVIVES clean, because the action cache does. The
build's own alias comments record what this cost once: the JS row of a GREEN
run executing 109 of 567 tests, with languageJS, passesJS and testkitJS never
running at all.
So the release gate that was supposed to be the last line of defence was the
one command in the procedure that could report success without running. The
tJVM/tJS/tNative aliases already exist to defeat exactly this -- they are
`testOnly *`, which ignores incremental state -- and the skill simply did not
use them.
Step 9 is now `sbt "; clean; tJVM; tJS; tNative; publish"`, with the reason
attached so it does not get "simplified" back, plus the instruction to count
`Suites: completed` lines and check for `No tests to run`.
Also adds the major-release rule Reid set while shipping 2.0.0: certify from a
genuinely COLD cache first, since clean does not clear the shared store. That
means shutdown (the -D applies only at server boot), a throwaway
localcache, and verifying afterwards that the directory grew -- an empty one
means nothing was actually cold.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>sbt clean test publish -- the gate could skip most of the suite1 parent 64f402d commit 6a70cf0
1 file changed
Lines changed: 29 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
99 | 126 | | |
100 | 127 | | |
101 | 128 | | |
| |||
0 commit comments