Add missing check in mysqlnd_auth.c - #21711
Open
kamil-tekiela wants to merge 1 commit into
Open
Conversation
Contributor
|
Looks good to me. It seems that it already read So the risk is that the client sends uninitialized memory to the server if the scramble is too short. @nikic Could you take a look at this? |
Member
Author
|
@bukka Should this PR be closed too? Are you still working on it? |
Member
|
I will check it so keep it open please. Not part of that other thing though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified by Claude. Not sure if it causes any issues currently, but judging by how other plugins operate, there should be a check here too. Claude believes there's a remote chance this could even be exploited, although I doubt it's a security issue.