fix: match record filter values against json storage regardless of cardinality (#202)

Record fields always persist to json_value because RecordFieldType is
declared as a multiChoice schema, but the filter branched on
allow_multiple and queried string_value for single-value fields. That
column is never populated, so filtering a single-value record field
returned no rows.

Also renders option labels as HTML. formatOptionWithAvatar() returns
avatar markup, which SelectFilter escaped by default, printing the raw
div in the dropdown.

Author: ManukMinasyan

src/Filament/Integration/Components/Tables/Filters/RecordFilter.php

@@ -4,6 +4,7 @@
 
 namespace Relaticle\CustomFields\Filament\Integration\Components\Tables\Filters;
 
+use Filament\Forms\Components\Select;
 use Filament\Tables\Filters\SelectFilter as FilamentSelectFilter;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
@@ -23,33 +24,28 @@ final class RecordFilter extends AbstractTableFilter
      */
     public function make(CustomField $customField): FilamentSelectFilter
     {
-        $isMultiSelect = $customField->settings->allow_multiple ?? false;
-
         $filter = FilamentSelectFilter::make($customField->getFieldName())
             ->multiple()
             ->label($customField->name)
             ->searchable()
-            ->native(false);
+            ->native(false)
+            ->modifyFormFieldUsing(fn (Select $field): Select => $field->allowHtml());
 
         $filter = $this->configureLookup($filter, $customField->lookup_type);
 
-        $filter->query(function (array $data, Builder $query) use ($customField, $isMultiSelect): Builder {
+        $filter->query(function (array $data, Builder $query) use ($customField): Builder {
             if (empty($data['values'])) {
                 return $query;
             }
 
-            return $query->whereHas('customFieldValues', function (Builder $q) use ($customField, $data, $isMultiSelect): void {
+            return $query->whereHas('customFieldValues', function (Builder $q) use ($customField, $data): void {
                 $q->where('custom_field_id', $customField->id);
 
-                if ($isMultiSelect) {
-                    $q->where(function (Builder $subQuery) use ($data): void {
-                        foreach ($data['values'] as $value) {
-                            $subQuery->orWhereJsonContains('json_value', $value);
-                        }
-                    });
-                } else {
-                    $q->whereIn('string_value', $data['values']);
-                }
+                $q->where(function (Builder $subQuery) use ($data): void {
+                    foreach ($data['values'] as $value) {
+                        $subQuery->orWhereJsonContains('json_value', $value);
+                    }
+                });
             });
         });
 

tests/Feature/Integration/Resources/Pages/ListRecordsTest.php

@@ -411,3 +411,43 @@
             ->assertTableColumnStateSet('custom_fields.internal_notes', 'Internal review needed', $draftPost);
     });
 });
+
+describe('Record Field Filtering', function (): void {
+    beforeEach(function (): void {
+        $this->section = CustomFieldSection::factory()->create([
+            'name' => 'Post Relations',
+            'entity_type' => Post::class,
+            'active' => true,
+        ]);
+    });
+
+    it('filters by a record field regardless of cardinality', function (bool $allowMultiple, string $code): void {
+        $field = CustomField::factory()->create([
+            'custom_field_section_id' => $this->section->id,
+            'name' => 'Related Post',
+            'code' => $code,
+            'type' => 'record',
+            'entity_type' => Post::class,
+            'lookup_type' => Post::class,
+            'settings' => new CustomFieldSettingsData(
+                visible_in_list: true,
+                list_toggleable_hidden: false,
+                allow_multiple: $allowMultiple,
+            ),
+        ]);
+
+        $target = Post::factory()->create();
+        $linked = Post::factory()->create();
+        $unlinked = Post::factory()->create();
+
+        $linked->saveCustomFieldValue($field, [$target->getKey()]);
+
+        livewire(ListPosts::class)
+            ->set(sprintf('tableFilters.custom_fields.%s.values', $code), [$target->getKey()])
+            ->assertCanSeeTableRecords([$linked])
+            ->assertCanNotSeeTableRecords([$unlinked]);
+    })->with([
+        'single-value' => [false, 'related_post_single'],
+        'multi-value' => [true, 'related_post_multi'],
+    ]);
+});