Skip to content

action-shellcheck doesn't fail when shellcheck binary is not found. #68

Description

@jgreat

What happened

The job still passed as green even though the step failed to run shellcheck.

What I expected

The job to fail when shellcheck failed to run.

Details

Full Logs: https://github.com/mobilecoinofficial/full-service/actions/runs/11920706158/job/33223246794

The Installing shellcheck step failed to install shellcheck. Probably because xz-utils are not installed on the runner, that part is on me. I did expect the job to fail because the command wasn't found.

Installing shellcheck ... https://github.com/koalaman/shellcheck
  tar (grandchild): xz: Cannot exec: No such file or directory
  tar (grandchild): Error is not recoverable: exiting now
  tar: Child died with signal 13
  tar: Error is not recoverable: exiting now
  cp: cannot stat 'shellcheck-v0.10.0/shellcheck': No such file or directory
 Running shellcheck ...
  /home/runner/_work/_actions/reviewdog/action-shellcheck/v1/script.sh: line 71: shellcheck: command not found
 Running shellcheck (suggestion) ...
  /home/runner/_work/_actions/reviewdog/action-shellcheck/v1/script.sh: line 101: shellcheck: command not found

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions