Skip to content

Add support for Rails 8 - #89

Open
sunny wants to merge 4 commits into
the-refinery:masterfrom
sunny:allow-rails-seven
Open

Add support for Rails 8#89
sunny wants to merge 4 commits into
the-refinery:masterfrom
sunny:allow-rails-seven

Conversation

@sunny

@sunny sunny commented Aug 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Required to support the latest version of Rails.

Simplified the loop as well in order for automated tools such as dependabot to more easily create automated pull requests.

Use this in your Gemfile in the meantime:

# Send emails through SparkPost.
# Using fork to support Rails 8
# See also https://github.com/the-refinery/sparkpost_rails/pull/89
gem "sparkpost_rails",
    git: "https://github.com/sunny/sparkpost_rails.git",
    ref: "1d90bc7026ad3e4fc9af09819d5afe80934b5475"

@sunny sunny changed the title Allow Rails 7 Add support for Rails 7 Aug 4, 2021
@sunny sunny changed the title Add support for Rails 7 Add support for Rails main branch Aug 19, 2021
@sunny sunny changed the title Add support for Rails main branch Add support for Rails main (7.0.0.alpha) Aug 19, 2021
@trueheart78 trueheart78 mentioned this pull request Dec 16, 2021
Open
@trueheart78

trueheart78 commented Dec 16, 2021

Copy link
Copy Markdown

Would it make sense to bump this to support support Rails 7.0.0 final?

@sunny sunny changed the title Add support for Rails main (7.0.0.alpha) Add support for Rails 7 Dec 16, 2021
@sunny

sunny commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Done!

@trueheart78

trueheart78 commented Dec 16, 2021

Copy link
Copy Markdown

Awesome!

Captain Marvel

@dpaola2

dpaola2 commented Apr 21, 2022

Copy link
Copy Markdown

Thanks for this. Wondering if this could be merged to master

@olliebennett

olliebennett commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown

I can confirm I've been using this branch in production for 2 months without any issues. Would love to see it released if possible! :)

@jmlagace

jmlagace commented Jun 27, 2022

Copy link
Copy Markdown

Any updates on this merge request?

@brandoncc

brandoncc commented Apr 17, 2023

Copy link
Copy Markdown

I'd love to see this merged :-)

@sunny sunny changed the title Add support for Rails 7 Add support for Rails 8 Apr 7, 2025
@sunny

sunny commented Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

Bumped to allow Rails 8.

@sunny

sunny commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@dgoerlich any chance we can merge this? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sunny @trueheart78 @dpaola2 @olliebennett @jmlagace @brandoncc