configure: a bare --enable-selftest means v2, not the v1 that cannot build

Author: kaleb-himes

configure.ac

@@ -8172,6 +8172,21 @@ AS_CASE([$ENABLED_SELFTEST],
         SELFTEST_VERSION="v2"
     ],
     ["no"],[SELFTEST_VERSION="none"],
+    ["yes"],[
+        # A bare --enable-selftest means the CURRENT selftest, which is v2.
+        # It used to fall through to the catch-all below and silently select
+        # v1 (wolfCrypt 3.14.2) -- a configuration that does not compile: v1
+        # withholds WC_SHA3_{224,256,384,512}_BLOCK_SIZE (sha3.h), which
+        # hash.h, hmac.h, hash.c, hmac.c and benchmark.c all reference
+        # unconditionally, and it declares a different wc_RsaPSS_CheckPadding_ex
+        # arity than asn.c calls.  The Jenkins job is named
+        # PRB-CAVP-selftest-v2 and passes a bare --enable-selftest, so it was
+        # asking for v2 and being given a v1 that cannot build.
+        # --enable-selftest=v1 still selects v1 for anyone who explicitly wants
+        # it; only the bare form changed.
+        ENABLED_SELFTEST="yes"
+        SELFTEST_VERSION="v2"
+    ],
     [
         # selftest v1 (wolfCrypt 3.14.2)
         ENABLED_SELFTEST="yes"