[checkout] Code generation: update services and models - #915
[checkout] Code generation: update services and models#915AdyenAutomationBot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Adyen Checkout API integration from version 71 to 72, modifying multiple models and services to align with the new API contract. Key changes include making holderName required in several payment method details, deprecating donationType in favor of type, removing several fields from DonationPaymentRequest, and introducing new authorization adjustment fields (adjustAuthType, adjustAuthorisationData) to PaymentAmountUpdateRequest and PaymentAmountUpdateResponse. A review of the changes identified an issue in PaymentAmountUpdateRequest where setting the nullable adjustAuthType field to null will trigger an unexpected warning in the error log because the setter lacks a null check before validating against allowed enum values.
| { | ||
| $this->container['amount'] = $amount; | ||
| $allowedValues = $this->getAdjustAuthTypeAllowableValues(); | ||
| if (!in_array($adjustAuthType, $allowedValues, true)) { |
There was a problem hiding this comment.
Since adjustAuthType is nullable (string|null), setting it to null is a valid operation. However, the setter does not check for null before validating against the allowed values, which will trigger an unexpected warning in the error log. We should check if the value is not null before validating.
if (!is_null($adjustAuthType) && !in_array($adjustAuthType, $allowedValues, true)) {4964d37 to
b730fd0
Compare
a0b8f5d to
f528534
Compare
6d4e075 to
2ea13d9
Compare
d4c7dd7 to
1d6f80f
Compare
1d6f80f to
5dd6cde
Compare
5dd6cde to
b74d30b
Compare
|



This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.