Skip to content

[checkout] Code generation: update services and models - #915

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/checkout
Open

[checkout] Code generation: update services and models#915
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/checkout

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the checkout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner July 13, 2026 09:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Adyen Checkout API integration from version 71 to 72, modifying multiple models and services to align with the new API contract. Key changes include making holderName required in several payment method details, deprecating donationType in favor of type, removing several fields from DonationPaymentRequest, and introducing new authorization adjustment fields (adjustAuthType, adjustAuthorisationData) to PaymentAmountUpdateRequest and PaymentAmountUpdateResponse. A review of the changes identified an issue in PaymentAmountUpdateRequest where setting the nullable adjustAuthType field to null will trigger an unexpected warning in the error log because the setter lacks a null check before validating against allowed enum values.

{
$this->container['amount'] = $amount;
$allowedValues = $this->getAdjustAuthTypeAllowableValues();
if (!in_array($adjustAuthType, $allowedValues, true)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since adjustAuthType is nullable (string|null), setting it to null is a valid operation. However, the setter does not check for null before validating against the allowed values, which will trigger an unexpected warning in the error log. We should check if the value is not null before validating.

        if (!is_null($adjustAuthType) && !in_array($adjustAuthType, $allowedValues, true)) {

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 7 times, most recently from 4964d37 to b730fd0 Compare July 20, 2026 14:17
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 5 times, most recently from a0b8f5d to f528534 Compare July 27, 2026 10:32
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 3 times, most recently from 6d4e075 to 2ea13d9 Compare August 4, 2026 17:18
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 3 times, most recently from d4c7dd7 to 1d6f80f Compare August 21, 2026 14:05
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant