3d tile traversal fix - #13710
Open
mzschwartz5 wants to merge 7 commits into
Open
Conversation
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
force-pushed
the
3d-tile-traversal-fix
branch
from
August 20, 2026 17:09
a079a19 to
412aef6
Compare
mzschwartz5
marked this pull request as ready for review
August 21, 2026 17:01
ggetz
reviewed
Aug 21, 2026
Comment on lines
+250
to
+256
| // Vector tilesets opt into relaxed empty-tile refinement so empty regions reached | ||
| // through implicit or external placeholders do not block their content siblings. | ||
| // Note: it's likely we don't need to limit this behavior to vector tilesets. However, | ||
| // we are being cautious of breaking changes to existing tilesets. | ||
| const isVectorTileset = root.tileset.hasExtension( | ||
| "3DTILES_content_gltf_vector", | ||
| ); |
Contributor
There was a problem hiding this comment.
We'll want to confirm and likely extend this behavior to all 3D Tiles 2.0 tilesets, when we have them. Could you open a dedicated issue?
Comment on lines
+274
to
+277
| // For vector tilesets only unloaded renderable content blocks refinement, so an empty | ||
| // tile at its resolved level of detail does not hold back its content siblings, | ||
| // including across implicit or external placeholders. All other tilesets keep the | ||
| // original behavior of blocking whenever traversal stops without content available. |
Contributor
There was a problem hiding this comment.
IIUC, this is "unconditional refinement" as described in https://github.com/CesiumGS/glTF/tree/3d-tiles-2.0/extensions/2.1/Vendor/3DTILES_tileset#unconditional-refinement. Maybe we should link to this directly for context.
Contributor
|
@xuanhuang1 Could you please confirm the behavior in this branch addresses your needs from #13686? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See linked issue. tl;dr - this bug fixes a niche edge case in tile traversal that manifests most obviously in vector-data tilesets.
Issue number and link
#13686
Testing plan
Use the vector data sandcastle linked from the issue
Tileset + traversal specs (with WebGL stub): 15362 passed, 0 failed, 73 skipped.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
Claude
If yes, I used the following Model(s):
Opus 4.8