Normalize default-mode parsing and add regression test - #716
Open
thb-hash wants to merge 1 commit into
Open
Conversation
- Normalize parsing of PONYTAIL_DEFAULT_MODE and config.defaultMode via normalizeMode() so whitespace and casing are accepted while 'review' remains invalid as a default. - Add unit test covering trimmed/normalized env and config values. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Environment and config values for the Ponytail default mode were not being normalized, so values with extra whitespace or unusual casing (for example, " FULL " or "\tultra\n") were ignored. This caused unexpected fallbacks or failures when users set defaults via env vars or config files.
What I changed
Notes & testing
Files changed
Reviewers: small utility fix; extra attention appreciated on the normalization and config-path logic on Windows paths if needed.