fix(hermes): stop filterSkillBodyForMode from swallowing rule bullets that start with a mode word - #720
Open
prayag0one4 wants to merge 1 commit into
Open
Conversation
… that start with a mode word
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team!, I noticed a bug in how the Python port handles instructions for the Hermes adapter.
_filter_skill_body_for_mode was accidentally swallowing perfectly valid rule bullets. The regex it was using didn't check for a closing quote (:\s*"), so if a normal instruction bullet happened to start with a word that matched a mode (like - Full: always write documentation), it thought it was a mode-specific example and silently dropped it from the prompt.
I updated the regex to match the JavaScript implementation by requiring the quote (re.match(r"^-\s*([^:]+):\s*"", line)).
What I tested:
Verified that normal instructions are preserved and only actual examples wrapped in quotes are mode-filtered.
Ran node tests/hermes-plugin.test.js locally and all tests are green.