ponytail-audit/review: no pass for over-defensive control flow or broad exception wrappers - #732
Open
Lockyer228 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ponytail-auditandponytail-reviewtarget structural slop you fix by deleting — speculative abstraction, reinvented stdlib, dead flexibility. But a common AI-shaped failure has nothing structurally redundant to cut: over-defensive control flow (deeply nested condition ladders, redundant guards) and blankettry/except/catchwrappers that swallow uncertainty.What
Add a
defensive:tag to both skills' vocabulary (byte-identical in both files, keeping audit's "Same as ponytail-review" true):Two review examples covering each symptom (redundant null-checking, broad
catch (Exception)), plus an audit Hunt entry following the issue's flatten, don't delete principle — explicitly never simplifying away error handling that prevents data loss.Tests
node --test tests/openclaw-skills.test.js→ 18/18node scripts/check-rule-copies.js→ exit 0npm test→ all pass except the pre-existingcsv: correct pandas one-liner passesfailure (fails identically on base; no pandas installed locally) — unrelated to this change.Fixes #682