chore: Dockerfile - Remove NCCL symlink - #240
Open
polarathene wants to merge 1 commit into
Open
Conversation
If the project is built properly with dynamic linking, this step should not be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the project is built properly with dynamic linking, this step should not be necessary (as was recently handled at
mistral.rsequivalentDockerfile).The
ENVandCOPYchanges are minor and reflect the same changes done atmistral.rs.Further context on removed symlink
The symlink addition for NCCL was snuck in via #220 among other changes that aren't reflected by the actual
Dockerfileatmistral.rs. Potentially as a means to cheat / disrespect the review process that contributor was already involved in withmistral.rs.In particular, for this symlink I had requested more information regarding it's relevancy.
This contributor has previously reported unexpected linking errors, then closed as resolved without any context as to what changed.
Personally this behaviour warrants concern when they contribute, so caution may be encouraged going forward when their changes lack context. This isn't uncommon with contributors, which while their additions can be valuable, it can accumulate with time and become a burden for maintainers to understand when they need to interact with these contributions to make decisions.