Omit explicit wp-tinymce dependency to work around third party vendor conflict - #269
Merged
Conversation
This is to work around a problem with the Toolset Types plugin.
mlwilkerson
marked this pull request as ready for review
October 2, 2025 22:32
mlwilkerson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR omits the
wp-tinymcedependency when registering this plugins classic editor JavaScript.This plugin's classic editor script does rely on the presence of the
tinymceglobal, hence the explicit declaration of that dependence. However, we found that doing this impacts loading order and/or execution time in a way that results in a bug that is observed in interaction with Toolset Types. See here.Customers experiencing that problem reported that this change resolves the issue. The root cause seems to be something to do with Toolset's assumptions. Toolset should not break due to changing the load order of standard scripts. However, this workaround seems low enough risk to do it anyway.