[cross-schema] Introduce PlanCacheSchemaKey and multi-schema QueryCacheKey - #4442
Draft
arnaud-lacurie wants to merge 4 commits into
Draft
[cross-schema] Introduce PlanCacheSchemaKey and multi-schema QueryCacheKey#4442arnaud-lacurie wants to merge 4 commits into
arnaud-lacurie wants to merge 4 commits into
Conversation
3 tasks
Replace raw String primary cache key with PlanCacheSchemaKey holding an ImmutableSortedSet of schema names. Replace single schemaTemplateVersion in QueryCacheKey with ImmutableSortedMap<String,Integer> schemaVersions, enabling cross-schema plan cache keying. Affects: PlanCacheSchemaKey (new), QueryCacheKey, RelationalPlanCache, AstNormalizer.NormalizationResult, PlanGenerator, and their tests.
arnaud-lacurie
force-pushed
the
apple/arnaud-lacurie/cross-schema/pr1
branch
from
August 14, 2026 16:48
f0c1db0 to
90fd710
Compare
arnaud-lacurie
changed the title
Checkstyle RedundantImport: PlanCacheSchemaKey lives in the same package as this test class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanCacheSchemaKey— a stable key component derived from a set of(schemaName, schemaVersion)pairs — so that a cached plan is invalidated when any participating secondary schema changesQueryCacheKeyto carry the secondary-schema set alongside the primary schema, giving each multi-schema query its own cache slotTest plan