Skip to content

[cross-schema] Add YAML integration tests and documentation for cross-schema joins - #4447

Draft
arnaud-lacurie wants to merge 2 commits into
apple/arnaud-lacurie/cross-schema/pr5from
apple/arnaud-lacurie/cross-schema/pr6
Draft

[cross-schema] Add YAML integration tests and documentation for cross-schema joins#4447
arnaud-lacurie wants to merge 2 commits into
apple/arnaud-lacurie/cross-schema/pr5from
apple/arnaud-lacurie/cross-schema/pr6

Conversation

@arnaud-lacurie

@arnaud-lacurie arnaud-lacurie commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • cross-schema-join.yamsql: end-to-end YAML tests covering basic inner join (with STORE_BIND explain check), WHERE pushdown, standalone secondary-schema query, three-schema join, and same-named-table type-collision avoidance across five schemas in one database; gated on !current_version
  • YamlIntegrationTests: wires in the new yamsql file
  • docs/sphinx/source/reference/Joins.rst: documents the schema_name.table_name qualifier syntax, same-database constraint, standalone secondary queries, and multi-schema join examples

Test plan

  • YamlIntegrationTests#crossSchemaJoinTests — all 7 test cases green
  • Documentation renders correctly in Sphinx

@arnaud-lacurie arnaud-lacurie added documentation Documentation change testing improvement Change that improves our testing labels Aug 14, 2026
@arnaud-lacurie
arnaud-lacurie force-pushed the apple/arnaud-lacurie/cross-schema/pr6 branch from 572bbf0 to 6729420 Compare August 14, 2026 16:48
@arnaud-lacurie arnaud-lacurie changed the title Add YAML integration tests and documentation for cross-schema joins (cross-schema 6/6) [cross-schema] Add YAML integration tests and documentation for cross-schema joins Aug 14, 2026
cross-schema-join.yamsql tests basic joins, WHERE pushdown, standalone
secondary-schema queries, three-schema joins, and same-named table
type-collision avoidance across five schemas in a single database.

YamlIntegrationTests wires in the new yamsql file.

Joins.rst documents the schema_name.table_name qualifier syntax,
the same-database constraint, and multi-schema join examples.
@arnaud-lacurie
arnaud-lacurie force-pushed the apple/arnaud-lacurie/cross-schema/pr6 branch from 6729420 to 4fb388e Compare August 14, 2026 18:50
table-as-column-tests.yamsql was deleted upstream in ca9cdd6
("Address Hazem's review comments on PR #4195"), which consolidated
its tests into select-a-star.yamsql. This branch had picked up the
now-stale registration via an old merge-forward sync with main, and
my conflict resolution kept it without noticing the backing file no
longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation change testing improvement Change that improves our testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant