Skip to content

Document ARRAY_AGG() - #4472

Open
robert-brunel wants to merge 2 commits into
apple/robert-brunel/array_agg-1from
apple/robert-brunel/array_agg-2
Open

Document ARRAY_AGG()#4472
robert-brunel wants to merge 2 commits into
apple/robert-brunel/array_agg-1from
apple/robert-brunel/array_agg-2

Conversation

@robert-brunel

Copy link
Copy Markdown
Contributor
  • Add a page about the ARRAY_AGG() aggregate function to the SQL Reference.
  • Drop the array-agg-correlated-subquery block from array-agg-tests.yamsql, along with the parent and child tables it used, since the new documentation-queries file covers the correlated-subquery forms.

@robert-brunel robert-brunel self-assigned this Aug 18, 2026
@robert-brunel robert-brunel added the documentation Documentation change label Aug 18, 2026
@robert-brunel
robert-brunel marked this pull request as ready for review August 18, 2026 10:24
@robert-brunel
robert-brunel force-pushed the apple/robert-brunel/array_agg-2 branch from 2709f67 to 6753f1d Compare August 18, 2026 18:33
* Add a page about the `ARRAY_AGG()` aggregate function to the SQL Reference.
* Drop the `array-agg-correlated-subquery` block from `array-agg-tests.yamsql`, along with the `parent` and `child` tables it used, since the new documentation-queries file covers the correlated-subquery forms.
@robert-brunel
robert-brunel force-pushed the apple/robert-brunel/array_agg-2 branch from 6753f1d to dc534c9 Compare August 24, 2026 11:16
Comment thread docs/sphinx/source/reference/Functions/aggregate_functions/array_agg.rst Outdated
Comment thread docs/sphinx/source/reference/Functions/aggregate_functions/array_agg.rst Outdated

The ``product_idx`` index is needed for the ``GROUP BY product`` query to be planned; see the note on required indexes under :ref:`Important Notes <array-agg-important-notes>`.

Collecting all values

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "collecting all values", but does not use ALL and actually ignores nulls. This does not seem right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants