-
Notifications
You must be signed in to change notification settings - Fork 125
Bump gradle-wrapper from 9.5.1 to 9.7.0 #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,7 +75,7 @@ def classLoader = plugins['com.github.spotbugs'].class.classLoader | |
| def SpotBugsEffort = classLoader.findLoadedClass('com.github.spotbugs.snom.Effort') | ||
| def SpotBugsTaskClass = classLoader.findLoadedClass('com.github.spotbugs.snom.SpotBugsTask') | ||
| spotbugs { | ||
| toolVersion = libs.versions.spotbugs.get() | ||
| toolVersion = rootProject.libs.versions.spotbugs.get() | ||
| ignoreFailures = false | ||
| effort = SpotBugsEffort.MAX | ||
| excludeFilter = rootProject.file('gradle/codequality/spotbugs_exclude.xml') | ||
|
|
@@ -119,7 +119,6 @@ apply plugin: 'pmd' | |
| pmd { | ||
| consoleOutput = true | ||
| ignoreFailures = false | ||
| targetJdk = '1.7' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is no longer necessary. PMD now figures this out from the JDK configuration. This has been deprecated with no replacement |
||
| sourceSets = [sourceSets.main] | ||
| toolVersion = '6.44.0' | ||
| // an annoying hack to get around Gradle defaults | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be referenced explicitly by
rootProjectto avoid a new deprecation warning (will become an error in Gradle 10). The exact situations where this must be done is very situational, and I've only made the changes where it's necessary by the build. This is in thesubprojectslambda of the mainbuild.gradlefile and in the files imported from that spot. It's not necessary in the bulk of cases (i.e., within a subproject file's list of dependencies)