NEST-608: Disable attribute-empty-style and update html-validate NPM package - #816
Open
sarahelsaig wants to merge 7 commits into
Open
NEST-608: Disable attribute-empty-style and update html-validate NPM package#816sarahelsaig wants to merge 7 commits into
sarahelsaig wants to merge 7 commits into
Conversation
sarahelsaig
changed the title
Piedone
approved these changes
Aug 28, 2026
Piedone
requested changes
Aug 31, 2026
Comment on lines
+802
to
+814
| private Task OnAssertCloudflareErrorPageAsync(UITestContext context) | ||
| { | ||
| // Using JavaScript is much faster | ||
| var isCloudflareErrorPage = context.ExecuteScript(CloudflareErrorPageDetectionJavaScript); | ||
| if (isCloudflareErrorPage is true) | ||
| { | ||
| throw new PageChangeAssertionException( | ||
| $"Cloudflare error page \"{context.Driver.Title}\" encountered. Check the \"PageSource.mhtml\" file " + | ||
| "in the test dump for more details."); | ||
| } | ||
|
|
||
| return Task.CompletedTask; | ||
| } |
Member
There was a problem hiding this comment.
Since this is remote test-specific for CF, it should rather be in CloudflareRemoteUITestBase.
Comment on lines
+34
to
+38
| <ItemGroup> | ||
| <EmbeddedResource Update="Recipes\Lombiq.Tenants.Core.Features.recipe.json"> | ||
| <CopyToPublishDirectory>Never</CopyToPublishDirectory> | ||
| </EmbeddedResource> | ||
| </ItemGroup> |
Member
There was a problem hiding this comment.
Is this actually needed, also for proper NuGet publishing? E.g. Lombiq.Walkthroughs and Lombiq.UIKit.Widgets don't have this for their recipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because it will never work. When passing the page source to html-validate using
await new HtmlValidator(options).ValidateAsync(context.Driver.PageSource)we will find that Chrome (also Firefox) converts the raw HTML into<div hidden>into<div hidden=\"\"></div>which violates the rule with that empty value. This can be confirmed in the browser's developer console by typingdocument.body.innerHTML = '<div hidden>'; alert(document.body.innerHTML).NEST-608