SS-148 Iceberg sink, don't attempt commit unless it's definitely not a duplicate - #38441
Draft
ublubu wants to merge 6 commits into
Draft
SS-148 Iceberg sink, don't attempt commit unless it's definitely not a duplicate#38441ublubu wants to merge 6 commits into
ublubu wants to merge 6 commits into
Conversation
Claude: on both retrial paths, check for other writers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #38333
We rely on MaterializeInc/iceberg-rust#7 making the Transaction commit internals public.
Then we reimplement Transaction commit, but without the built-in rebase+retry.
Previously,
iceberg-rustloaded the table from the Catalog on every commit attempt, applying the transaction's actions on top of the latest state of the table.With this PR, Mz loads the table from the Catalog on every commit attempt, but it does not apply the transaction's action on top of the latest state of the table until after it inspects the table state (for funny business like a previously successful attempt or another writer taking over).