Skip to content

build: clear Gradle 10 deprecations, bump wrapper to 9.7.1 - #80

Open
soloturn wants to merge 2 commits into
preview/v4.x-SNAPSHOTfrom
build/clear-gradle-10-deprecations
Open

build: clear Gradle 10 deprecations, bump wrapper to 9.7.1#80
soloturn wants to merge 2 commits into
preview/v4.x-SNAPSHOTfrom
build/clear-gradle-10-deprecations

Conversation

@soloturn

@soloturn soloturn commented Aug 16, 2026

Copy link
Copy Markdown

AI-assisted change proposal. Filed by agent driven by @soloturn via GDD.

Summary

  • Clears the Gradle-10-scheduled-for-removal deprecations found building against Gradle 9.7.1: Groovy space-assignment in gradle/common.gradle, multi-string dependency notation in each subproject's build.gradle, and implicit parent-project property lookups (nuiVersion, jomlVersion, geomVersion).
  • Bumps the wrapper from 8.2.1 to 9.7.1 so the warnings are visible at all.

Test plan

  • ./gradlew build -x test --warning-mode=all — clean of Gradle-10 warnings, BUILD SUCCESSFUL.

Related

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b53bcb26-ade6-44a3-88a5-6c49886945db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenjaminAmos
BenjaminAmos changed the base branch from master to preview/v4.x-SNAPSHOT August 17, 2026 11:11

@BenjaminAmos BenjaminAmos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this change (or a previous one) broke the JUnit tests.

org.gradle.api.internal.tasks.testing.RequiresTestFrameworkTestDefinitionProcessor$TestFrameworkNotAvailableException: Failed to load JUnit Platform.  Please ensure that all JUnit Platform dependencies are available on the test's runtime classpath, including the JUnit Platform launcher.
    at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestDefinitionProcessor.assertTestFrameworkAvailable(JUnitPlatformTestDefinitionProcessor.java:101)
    at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestDefinitionProcessor.startProcessing(AbstractJUnitTestDefinitionProcessor.java:50)
    at org.gradle.api.internal.tasks.testing.SuiteTestDefinitionProcessor.startProcessing(SuiteTestDefinitionProcessor.java:43)

@soloturn

Copy link
Copy Markdown
Author

Fixed in 6b3616e - Gradle 9 dropped the auto-supplied JUnit Platform Launcher, so bumping the wrapper here needed it declared explicitly. Added testRuntimeOnly("org.junit.platform:junit-platform-launcher:1.6.2") to nui/build.gradle, version-paired with the existing junit-jupiter 5.6.2. Jenkins is green on the current head including the test stage.

soloturn and others added 2 commits August 21, 2026 22:45
gradle/common.gradle used Groovy space-assignment for sourceCompatibility,
name, url, and allowInsecureProtocol, plus a bare `nuiVersion` read that
implicitly resolves from the root project - all three removed in Gradle 10.

Each subproject's build.gradle declared dependencies with the multi-string
`group:`/`name:`/`version:` map form (also removed) and read `jomlVersion`/
`geomVersion` the same implicit way; switched to single-string coordinates
and `rootProject.<name>`.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Gradle 9 dropped the auto-supplied JUnit Platform Launcher test
dependency, so bumping the wrapper to 9.7.0 in this PR made
:nui:test fail immediately with 'Failed to load JUnit Platform' -
before any test even ran. Declare it explicitly as testRuntimeOnly,
version-paired with the existing junit-jupiter 5.6.2.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@soloturn
soloturn force-pushed the build/clear-gradle-10-deprecations branch 2 times, most recently from 38219f7 to 54a6ca3 Compare August 21, 2026 20:47
@soloturn soloturn changed the title build: clear Gradle 10 deprecations, bump wrapper to 9.7.0 build: clear Gradle 10 deprecations, bump wrapper to 9.7.1 Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants