build: clear Gradle 10 deprecations, bump wrapper to 9.7.1 - #80
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
BenjaminAmos
left a comment
There was a problem hiding this comment.
It appears that this change (or a previous one) broke the JUnit tests.
org.gradle.api.internal.tasks.testing.RequiresTestFrameworkTestDefinitionProcessor$TestFrameworkNotAvailableException: Failed to load JUnit Platform. Please ensure that all JUnit Platform dependencies are available on the test's runtime classpath, including the JUnit Platform launcher.
at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestDefinitionProcessor.assertTestFrameworkAvailable(JUnitPlatformTestDefinitionProcessor.java:101)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestDefinitionProcessor.startProcessing(AbstractJUnitTestDefinitionProcessor.java:50)
at org.gradle.api.internal.tasks.testing.SuiteTestDefinitionProcessor.startProcessing(SuiteTestDefinitionProcessor.java:43)
|
Fixed in 6b3616e - Gradle 9 dropped the auto-supplied JUnit Platform Launcher, so bumping the wrapper here needed it declared explicitly. Added |
gradle/common.gradle used Groovy space-assignment for sourceCompatibility, name, url, and allowInsecureProtocol, plus a bare `nuiVersion` read that implicitly resolves from the root project - all three removed in Gradle 10. Each subproject's build.gradle declared dependencies with the multi-string `group:`/`name:`/`version:` map form (also removed) and read `jomlVersion`/ `geomVersion` the same implicit way; switched to single-string coordinates and `rootProject.<name>`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Gradle 9 dropped the auto-supplied JUnit Platform Launcher test dependency, so bumping the wrapper to 9.7.0 in this PR made :nui:test fail immediately with 'Failed to load JUnit Platform' - before any test even ran. Declare it explicitly as testRuntimeOnly, version-paired with the existing junit-jupiter 5.6.2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
38219f7 to
54a6ca3
Compare
Summary
gradle/common.gradle, multi-string dependency notation in each subproject'sbuild.gradle, and implicit parent-project property lookups (nuiVersion,jomlVersion,geomVersion).Test plan
./gradlew build -x test --warning-mode=all— clean of Gradle-10 warnings, BUILD SUCCESSFUL.Related