Skip to content

fix(rendering): actually suppress FBO resize-to-zero on minimize #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soloturn wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −4
Open

fix(rendering): actually suppress FBO resize-to-zero on minimize #5372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions engine/src/main/java/org/terasology/engine/core/subsystem/lwjgl/LwjglDisplayDevice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,23 @@ private void updateViewport() {

protected void updateViewport(int width, int height) {
glViewport(0, 0, width, height);

//If the screen is minimized, resolution change is stopped to avoid the width and height of FBO being set to 0.

// GLFW reports the framebuffer as 0x0 while the window is minimized, and
// DisplayResolutionDependentFbo.propertyChange regenerates every resolution-dependent FBO at
// whatever size the display device reports whenever this event fires - it does not look at
// the old/new values below, only at whether the event fired at all. So an unconditional fire
// here means minimizing regenerates every FBO at 0x0, and restoring the window leaves them
// that way until something else triggers a further resize - the black screen on restore this
// is meant to prevent (#4980, #5081).
//
// PropertyChangeSupport.firePropertyChange skips notifying listeners when old equals new, so
// that is used here as the on/off switch: while minimized, pass (1, 1) so the compare matches
// and nothing fires; otherwise pass (0, 1) so a genuine resize still does. This was previously
// inverted - isMinimized picked the value that differs from newValue, the opposite of what
// "stop the resolution change" requires - so it suppressed real resizes instead of minimizes.
boolean isMinimized = GLFW.glfwGetWindowAttrib(GLFW.glfwGetCurrentContext(), GLFW.GLFW_ICONIFIED) == GLFW.GLFW_TRUE;
int i = isMinimized ? 0 : 1;
propertyChangeSupport.firePropertyChange(DISPLAY_RESOLUTION_CHANGE, i, 1);
int oldValue = isMinimized ? 1 : 0;
propertyChangeSupport.firePropertyChange(DISPLAY_RESOLUTION_CHANGE, oldValue, 1);
}

private GLFWVidMode getFullScreenDisplayMode() {
Expand Down
Loading