Skip to content

[TASK] Allow PHP 8.6 with PHPStan extension #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 1 commit into from
Aug 29, 2026
Merged

[TASK] Allow PHP 8.6 with PHPStan extension #1648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions tests/Unit/PhpStan/IgnoreBooleanAlwaysImpossibleAssertTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use PHPStan\Analyser\IgnoreErrorExtension;
use PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRule;
use PHPStan\Rules\Rule;
use PHPUnit\Framework\Error\Deprecated;

/**
* This covers `function.alreadyNarrowedType` error handling in the `IgnoreBooleanAlways` PHPStan extension class.
Expand Down Expand Up @@ -39,15 +40,22 @@ public function warningIsRetainedForPointlessAssert(): void
self::markTestSkipped('This is testing the testers, and only needs to run whenever possible.');
}

// Second argument is array of expected warnings.
$this->analyse(
[self::FIXTURES_DIR . 'alwaystrue-pointlessassert.php'],
[
// TODO: remove try/catch block when PHPStan is fixed.
try {
// Second argument is array of expected warnings.
$this->analyse(
[self::FIXTURES_DIR . 'alwaystrue-pointlessassert.php'],
[
'Call to function is_int() with int will always evaluate to true.',
7,
[
'Call to function is_int() with int will always evaluate to true.',
7,
],
],
],
);
);
} catch (Deprecated $e) {
self::markTestSkipped(
'PHPStan has a dependency on an Hoa library that triggers a deprecation warning with PHP 8.6.'
);
}
}
}