fix: LoginScreen does not appear immediately and you can see NotesScreen for a second - #821
Open
aguragorn wants to merge 1 commit into
Open
fix: LoginScreen does not appear immediately and you can see NotesScreen for a second#821aguragorn wants to merge 1 commit into
aguragorn wants to merge 1 commit into
Conversation
…een for a second ### What: - When the user is logged out the app briefly shows the NotesScreen before redirecting to LoginScreen ### Why: - The initial screen configured in navigation is NotesScreen ### How: - Dynamically choose start destination based on login state - Add instrumentation tests to ensure correct start destination
| NotyTheme(darkTheme = LocalUiInDarkMode.current) { | ||
| Surface { | ||
| NotyNavigation() | ||
| NotyNavigation(state.isLoggedIn == true) |
Owner
There was a problem hiding this comment.
I think this will still not solve a problem and could cause recompositions from navigation layer itself as isLoggedIn is by default null so value could be changed twice
- null -> false
- null -> true
So I think it'll still cause problems?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
How:
Checklist