Add new 9.2.0 hooks to the SQL upgrade script - #1895
Closed
mattgoud wants to merge 1 commit into
Closed
Conversation
Generated with:
php bin/console prestashop:update:sql-upgrade-file-hooks-listing 9.1.5 <autoupgrade>
9.1.5 is the base: it is the last 9.1.x release, and there is no
9.2.0-beta.1.sql, so 9.2.0.sql must cover the whole 9.1.5 -> 9.2.0 delta.
45 new hooks were reported, and no obsolete ones, so no DELETE statement is
needed.
The command appends its block without looking at what the file already
contains, so actionCheckoutBuildProcess ended up listed twice: once in the
generated block, once in the insert added earlier by PR #41047. Both inserts
have been merged into the single generated block, which now holds all 45
hooks, and a comment records where that one row comes from.
Verified: all 45 hooks already exist with identical title and description in
a freshly installed 9.2.0 database, so the block is a no-op there and stays
consistent with the install-dev fixtures.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mattgoud
force-pushed
the
add/9.2.0-hooks-listing
branch
from
August 27, 2026 13:48
fd826b3 to
e4fd37d
Compare
|
Contributor
Author
|
Closing: this was already done. It also targeted the wrong branch: One genuine gap came out of the exercise and is being opened separately against |
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the new 9.2.0 hooks to
upgrade/sql/9.2.0.sql, as part of the 9.2.0-rc.1 release process.Generated with:
9.1.5is the comparison base: it is the last 9.1.x release, and there is no9.2.0-beta.1.sql, so9.2.0.sqlhas to cover the whole 9.1.5 → 9.2.0 delta.The command reported 45 new hooks and no obsolete ones, so no
DELETEstatement is needed.One manual adjustment
The command appends its block without looking at what the file already contains, so
actionCheckoutBuildProcessended up listed twice: once in the generated block, once in the insert added earlier by #41047.Both inserts have been merged into the single generated block, which now holds all 45 hooks, and a comment records where that one row comes from. The file is left with a single
INSERT INTO PREFIX_hookstatement.How to test
titleanddescriptionin a freshly installed 9.2.0 database, so the block is a no-op there and stays consistent with theinstall-devfixtures. On an upgraded shop it inserts the missing rows, andON DUPLICATE KEY UPDATErefreshes titles and descriptions.SELECT name, COUNT(*) FROM ps_hook GROUP BY name HAVING COUNT(*) > 1returns nothing —ps_hook.nameis aUNIQUE KEYand no hook is listed twice in the file.