fix(rocjitsu): Populate KFD CPU node name - #10569
Open
RattataKing wants to merge 1 commit into
Open
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
atgutier
approved these changes
Aug 21, 2026
kuhar
reviewed
Aug 22, 2026
|
|
||
| write_file(node_dir + "/gpu_id", "0\n"); | ||
| // KFD publishes a name file for every topology node. | ||
| write_file(node_dir + "/name", ""); |
Member
There was a problem hiding this comment.
We should write "\n" here and pin that exact value in sysfs_test.cpp. Both the live KFD CPU node on this machine and the in-tree captured topology contain the single byte 0a, and the GPU path already appends the same newline. write_file(..., "") instead creates a zero-byte file, so line-based readers such as std::getline see EOF rather than a readable empty name. A focused Sysfs::generate() check for nodes/0/name == "\n" would cover both the presence of the attribute and its KFD-compatible contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocprofiler-sdk unconditionally checks every KFD topology node’s name file. Add the missing name file to rocjitsu's simulated CPU node to resolve this compatibility issue.
Close issue: #10566