Skip to content

chore(rendering): remove the Clamp Lighting effect #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soloturn wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(rendering): remove the Clamp Lighting effect #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions assets/shaders/lightGeometryPass_frag.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,6 @@ void main() {
color *= attenuation * max(dot(lightDir/ lightDist, normal), 0);
#endif

// TODO A 3D wizard should take a look at this. Configurable for the moment to make better comparisons possible.
#if defined (CLAMP_LIGHTING)
outLight.rgba = clamp(vec4(color.r, color.g, color.b, specular), 0.0, 1.0);
#else
outLight.rgba = vec4(color.r, color.g, color.b, specular);
#endif

}
Binary file removed docs/_media/img/graphic-effects_clamp-lighting.jpg
View file
Open in desktop
Binary file not shown.
15 changes: 0 additions & 15 deletions docs/graphics-effects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ This minimal setup (not to confuse with the "Minimal" preset) results in the fol
"meshLimit": 400,
"inscattering": false,
"localReflections": false,
"clampLighting": false,
"volumetricFog": false
}
}
Expand Down Expand Up @@ -105,20 +104,6 @@ The following screenshots show the graphic setting baseline to the left and only
<fig-side-by-side src1="_media/img/graphic-effects_blur-normal.jpg" src2="_media/img/graphic-effects_blur-max.jpg">"Blur" Effect on Level "Normal" (left) and "Blur" Effect on Level "Max" (right)</fig-side-by-side>


## Clamp Lighting

Clamp Lighting can be enabled with the following config adjustment:
```json5
{
"clampLighting": true
}
```

The following screenshots show the graphic setting baseline to the left and only the "Clamp Lighting" effect enabled to the right.

<fig-side-by-side src1="_media/img/graphic-effects_baseline.jpg" src2="_media/img/graphic-effects_clamp-lighting.jpg">Baseline (left) and "Clamp Lighting" Effect (right)</fig-side-by-side>


## Cloud Shadows

Cloud Shadows can be enabled with the following config adjustment:
Expand Down
Loading