fix(navigation): Prevent infinite recursion in nav feedback script - #441
Open
sentry[bot] wants to merge 1 commit into
Open
fix(navigation): Prevent infinite recursion in nav feedback script#441sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
RangeError: Maximum call stack size exceededthat occurred during client-side navigation, particularly on Chrome Mobile iOS.Root Cause:
The
setPendingandclearPendingfunctions insrc/layouts/layout.astro(within the inline navigation feedback script) modify DOM attributes (data-nav-pending) ondocument.bodyand anchor elements. On certain browsers (observed on Chrome Mobile iOS), these DOM mutations were found to re-trigger Astro'sastro:before-preparationandastro:page-loadnavigation lifecycle events. Since the event listeners for these events call back intosetPending(null)andclearPendingrespectively, an infinite mutual recursion loop was created, leading to a stack overflow.Solution:
An
isUpdatingre-entrancy guard flag has been introduced within the IIFE scope of the navigation feedback script. BothsetPendingandclearPendingnow check this flag at their entry point. IfisUpdatingis true, the function immediately returns, preventing re-entrant calls from causing infinite recursion. The flag is set totrueat the beginning of the function's execution and reset tofalseat the end.Fixes BLOG-63
This PR was automatically generated by Sentry. You can adjust this setting at any time.